Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove any in index.d.ts #325

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

intellectus-rojiwon
Copy link
Contributor

In TS, the any type interferes with normal type inference. It's also potentially dangerous, so I recommend using unknown. We have changed the type any in the index.d.ts file to unknown to improve the type stability of the library usage.

Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You may want to see if there are any similar issues in winston-transport and winston. Thanks for the contribution!

@DABH DABH merged commit 55f3d8c into winstonjs:master Oct 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants