Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ESLint config #142

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Update ESLint config #142

merged 1 commit into from
Feb 11, 2022

Conversation

DABH
Copy link
Contributor

@DABH DABH commented Feb 5, 2022

No description provided.

@wbt
Copy link
Contributor

wbt commented Feb 11, 2022

Any particular reason for this change?
Though your fork may be up-to-date as of the pull request, it seems likely to quickly fall behind, possibly producing some dependency issues as seen elsewhere, and we won't know why this change was made to make an informed decision about switching back. There may be good reason for the switch, but please document that reason here before merging.
Thanks for all your contributions!

@DABH
Copy link
Contributor Author

DABH commented Feb 11, 2022

@wbt The intent is (1) to use the same lint rules etc. we’ve already been using, but (2) to have a copy of the config rules that we can maintain (I can merge PRs for dependabot alerts for example). Not a huge deal since this is only for dev dependencies, but still nice to have a solution that — for now — guards against dependency rot

@DABH
Copy link
Contributor Author

DABH commented Feb 11, 2022

(There is no reason to switch back since the previous fork is not maintained, but if I ever disappear, you may want to switch to a standard config and just deal with reformatting the repos according to some different rule sets. Or fork my fork and update again.)

@DABH DABH merged commit 0ab2982 into master Feb 11, 2022
@DABH DABH deleted the update-eslint-config branch February 11, 2022 16:36
@wbt
Copy link
Contributor

wbt commented Feb 11, 2022

Did you ask @indexzero about possibly getting commit rights in that repo, if he's not maintaining it anymore?
Then the fixes could benefit the whole subset of the npm ecosystem that uses it.

@DABH
Copy link
Contributor Author

DABH commented Feb 11, 2022

I don’t remember, but I think we were approximately the only folks using that repo

@wbt
Copy link
Contributor

wbt commented Feb 11, 2022

My fuzzy memory is that it was one of the options presented in eslint-init, which could mean more. npm reports 1474 weekly downloads, which isn't much but I think is more than can be accounted for by Winston maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants