[dev] remove the restriction of H.264 encoded video only gop cache. #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: ngx_http_flv_live_module.c ngx_rtmp_notify_module.c ngx_rtmp_stat_module.c
|
Confirmed that it was OK. Thanks! |
winshining
added a commit
that referenced
this pull request
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @winshining, I got some streams whose video codec ids were not
NGX_RTMP_VIDEO_H264butNGX_RTMP_VIDEO_SORENSON_H263(some so old videos). I found that it took more time to see the first pictures however I turned on/off the GOP cache than H.264 encoded videos.So I removed some lines (It took me so much time to find it). I think it's better not restrict GOP cache to H.264 encoded ONLY video and I've tested some times and it worked fine. Any advice?