Compiler Error

[DoM1niC]

Since I updated my compile VM to the last Packages from Debian SID, I got this error on my Maschine.

/root/sources/nginx-http-flv-module-master/ngx_rtmp_eval.c: In function ‘ngx_rtmp_eval’:
/root/sources/nginx-http-flv-module-master/ngx_rtmp_eval.c:161:17: error: this statement may fall through [-Werror=implicit-fallthrough=]
                 switch (c) {
                 ^~~~~~
/root/sources/nginx-http-flv-module-master/ngx_rtmp_eval.c:171:13: note: here
             case ESCAPE:
             ^~~~
cc1: all warnings being treated as errors
make[1]: *** [objs/Makefile:1611: objs/addon/nginx-http-flv-module-master/ngx_rtmp_eval.o] Fehler 1
make[1]: Verzeichnis „/root/sources/nginx-1.15.6“ wird verlassen
make: *** [Makefile:11: install] Fehler 2

Compiling without FLV Modul -> Success

[winshining]

Add

/* fall through */

between line 170 and line 171 and try again.
Looking forward to your reply because I don't have environment as yours.

[DoM1niC]

Dont work,

gcc version 8.2.0

                /* fall through */

            case NORMAL:
                switch (c) {
                    case '$':
                        name.data = p + 1;
                        state = NAME;
                        continue;
                    case '\\':
                        state = ESCAPE;
                        continue;
                }

		/* fall through */

            case ESCAPE:
                ngx_rtmp_eval_append(&b, &c, 1, log);
                state = NORMAL;
                break;

        }
    }

Log

/root/sources/nginx-http-flv-module-master/ngx_rtmp_script.c: In function ‘ngx_rtmp_script_add_copy_code’:
/root/sources/nginx-http-flv-module-master/ngx_rtmp_script.c:699:18: error: cast between incompatible function types from ‘size_t (*)(ngx_rtmp_script_engine_t *)’ {aka ‘long unsigned int (*)(struct <anonymous> *)’} to ‘void (*)(ngx_rtmp_script_engine_t *)’ {aka ‘void (*)(struct <anonymous> *)’} [-Werror=cast-function-type]
     code->code = (ngx_rtmp_script_code_pt) ngx_rtmp_script_copy_len_code;
                  ^
/root/sources/nginx-http-flv-module-master/ngx_rtmp_script.c: In function ‘ngx_rtmp_script_add_var_code’:
/root/sources/nginx-http-flv-module-master/ngx_rtmp_script.c:788:18: error: cast between incompatible function types from ‘size_t (*)(ngx_rtmp_script_engine_t *)’ {aka ‘long unsigned int (*)(struct <anonymous> *)’} to ‘void (*)(ngx_rtmp_script_engine_t *)’ {aka ‘void (*)(struct <anonymous> *)’} [-Werror=cast-function-type]
     code->code = (ngx_rtmp_script_code_pt) ngx_rtmp_script_copy_var_len_code;
                  ^
/root/sources/nginx-http-flv-module-master/ngx_rtmp_script.c: In function ‘ngx_rtmp_script_add_capture_code’:
/root/sources/nginx-http-flv-module-master/ngx_rtmp_script.c:921:18: error: cast between incompatible function types from ‘size_t (*)(ngx_rtmp_script_engine_t *)’ {aka ‘long unsigned int (*)(struct <anonymous> *)’} to ‘void (*)(ngx_rtmp_script_engine_t *)’ {aka ‘void (*)(struct <anonymous> *)’} [-Werror=cast-function-type]
     code->code = (ngx_rtmp_script_code_pt)
                  ^
/root/sources/nginx-http-flv-module-master/ngx_rtmp_script.c: In function ‘ngx_rtmp_script_add_full_name_code’:
/root/sources/nginx-http-flv-module-master/ngx_rtmp_script.c:1036:18: error: cast between incompatible function types from ‘size_t (*)(ngx_rtmp_script_engine_t *)’ {aka ‘long unsigned int (*)(struct <anonymous> *)’} to ‘void (*)(ngx_rtmp_script_engine_t *)’ {aka ‘void (*)(struct <anonymous> *)’} [-Werror=cast-function-type]
     code->code = (ngx_rtmp_script_code_pt) ngx_rtmp_script_full_name_len_code;
                  ^
/root/sources/nginx-http-flv-module-master/ngx_rtmp_eval.c: In function ‘ngx_rtmp_eval’:
/root/sources/nginx-http-flv-module-master/ngx_rtmp_eval.c:161:17: error: this statement may fall through [-Werror=implicit-fallthrough=]
                 switch (c) {
                 ^~~~~~
/root/sources/nginx-http-flv-module-master/ngx_rtmp_eval.c:171:13: note: here
             case ESCAPE:
             ^~~~

[winshining]

gcc-8.2.0 is a very very new version!

            /* fall through */

        case NORMAL:
            switch (c) {
                case '$':
                    name.data = p + 1;
                    state = NAME;
                    continue;
                case '\\':
                    state = ESCAPE;
                    continue;

                /* the following lines are new added */
                default:
                    break;
            }

        /* if the above modification doesn't work, add the following line */
        /* fall through */

        case ESCAPE:
            ngx_rtmp_eval_append(&b, &c, 1, log);
            state = NORMAL;
            break;
    }
}

Will this work then?

[winshining]

Other errors can be corrected by:

line 699:
before:
code->code = (ngx_rtmp_script_code_pt) ngx_rtmp_script_copy_len_code;
after:
code->code = (ngx_rtmp_script_code_pt) (void *) ngx_rtmp_script_copy_len_code;

line 788:
before:
code->code = (ngx_rtmp_script_code_pt) ngx_rtmp_script_copy_var_len_code;
after:
code->code = (ngx_rtmp_script_code_pt) (void *) ngx_rtmp_script_copy_var_len_code;

line 921:
before:
code->code = (ngx_rtmp_script_code_pt)
                        ngx_rtmp_script_copy_capture_len_code;
after:
code->code = (ngx_rtmp_script_code_pt) (void *)
                        ngx_rtmp_script_copy_capture_len_code;

line 1036:
before:
code->code = (ngx_rtmp_script_code_pt) ngx_rtmp_script_full_name_len_code;
after:
code->code = (ngx_rtmp_script_code_pt) (void *) ngx_rtmp_script_full_name_len_code;

I found some lines in nginx-1.15.2 has been changed like above.

[winshining]

@DoM1niC The bug is fixed, you can fetch the latest code and test.