Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved filter design #147

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Conversation

VishakhaSainani
Copy link
Contributor

@VishakhaSainani VishakhaSainani commented Oct 23, 2023

fixes : #141

Screenshots:
React Quiz Component Demo - Google Chrome 23-10-2023 23_57_26
React Quiz Component Demo - Google Chrome 23-10-2023 23_57_42

I used div , li and ul were giving lint errors. Check this out.

@VishakhaSainani
Copy link
Contributor Author

@wingkwong Please review it.

Copy link
Owner

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. the filter is not working at all...
  2. the new filter is a bit large. You may refer to ant design select - the first one in basic usage. It's close to my expectation.
  3. wrap the style by .react-quiz-container. i.e. .react-quiz-container .quiz-result-filter
  4. need a better name for custom-select

@VishakhaSainani
Copy link
Contributor Author

@wingkwong Requested changes updated please check.

Copy link
Owner

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now it's better. got some comments left.

  • the select is a bit large. let's set the height to 32px.
  • make the arrow down a bit smaller
  • the select option should be overlap the content instead of pushing it down
  • there is a slide effect when you open the options then un-focus. please remove that.

src/lib/styles.css Show resolved Hide resolved
@VishakhaSainani
Copy link
Contributor Author

VishakhaSainani commented Oct 25, 2023

@wingkwong

  • the select is a bit large. let's set the height to 32px
    Can you please elaborate this one, of what item exactly the height needs to be changed. The select button or the cursor arrow or the dropdown menu.

Check it out now :-
Screenshots:-
React Quiz Component Demo - Google Chrome 25-10-2023 20_09_18
image

@wingkwong
Copy link
Owner

Can you please elaborate this one, of what item exactly the height needs to be changed. The select button or the cursor arrow or the dropdown menu.

The overall height. Now it's 42px. Change to 32px. The text and arrow down icon can be a bit smaller.

image

@VishakhaSainani
Copy link
Contributor Author

@wingkwong Check it out. Thankyou.

Copy link
Owner

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • open a select option list, unfocus should close the list.
  • the font size of selected option and that of options in the list are not aligned
  • the gap between the select and the list should be reduced a bit
    image

src/lib/styles.css Outdated Show resolved Hide resolved
src/lib/styles.css Outdated Show resolved Hide resolved
src/lib/styles.css Outdated Show resolved Hide resolved
src/lib/styles.css Outdated Show resolved Hide resolved
src/lib/styles.css Outdated Show resolved Hide resolved
@VishakhaSainani
Copy link
Contributor Author

@wingkwong I hope it's good enough now, check it out. Thankyou

@wingkwong wingkwong merged commit 6b00da4 into wingkwong:develop Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve the filter design
2 participants