-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved filter design #147
Conversation
@wingkwong Please review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the filter is not working at all...
- the new filter is a bit large. You may refer to ant design select - the first one in basic usage. It's close to my expectation.
- wrap the style by
.react-quiz-container
. i.e..react-quiz-container .quiz-result-filter
- need a better name for
custom-select
@wingkwong Requested changes updated please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now it's better. got some comments left.
- the select is a bit large. let's set the height to 32px.
- make the arrow down a bit smaller
- the select option should be overlap the content instead of pushing it down
- there is a slide effect when you open the options then un-focus. please remove that.
|
@wingkwong Check it out. Thankyou. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wingkwong I hope it's good enough now, check it out. Thankyou |
fixes : #141
Screenshots:
I used div , li and ul were giving lint errors. Check this out.