Adding Footer and Front-End Improvements #655

ajay-dhangar · 2023-10-02T14:46:11Z

Change Summary

closes: #652

Navbar
Footer
About section

Checklist

If you haven't fulfilled the below requirements or even delete the entire checklist, your PR won't be reviewed and will be closed without notice. Regular contributors (with 10+ PRs) can skip this part.

General

This Pull Request is all my own work. (You'll be blacklisted if you are caught for plagiarism.)
I've read CONTRIBUTING.md
I've applied LaTex for all variables, formulas and time / space complexity instead of using backticks
I've started the app locally and verified all the content and all links (if applicable) are accessible correctly
I've included Complexity Analysis (Time Complexity & Space Complexity).
I've written my explanation well and it is easy to understand for beginners

Tutorial

I've read and followed the Tutorial Template
I've explained my topic well with 2 - 3 LC problems and no external problems are used.
I've provided the full working solutions to the problems used in this tutorial.
I've provided suggested problems at the end with the given format. See here as an example. If the target solution is not available, leave solutionLink blank.
I've given credits / references if I use external resources. (For an image, give credit under it. Otherwise, add a new section called References at the end (after Suggested Problems).)

Solutions

I've read and followed the Solution Template
I've formatted my code well with K&R Coding style
I've confirmed that comments are put above each line rather than writing on the same line.
I've included a meaningful approach name for my solution. e.g. ## Approach 1: Two Pointers.

ajay-dhangar

Added code for Footer, Navbar, about section and Front-End Improvements with responsive way. (Complited)

wingkwong

The UI looks even worse now.

ajay-dhangar

Now this

wingkwong

please fix the indentation in docusaurus.config.js
those icons are unused and can be removed
don't commit src/pages/index.module.css when you just add a line break
the issue you mentioned is not fixed

ajay-dhangar

ok I do to work but i want to say to you can remove emoji's.

wingkwong · 2023-10-03T02:34:47Z

@ajay-dhangar not a good solution.

ajay-dhangar

updated

wingkwong

please remove those unused icon images.

docusaurus.config.js

ajay-dhangar

docusaurus.config.js

items: [
          {
            html: '<span class="nav-emoji">📚</span> Tutorials',
            to: '/tutorials/category/basic-topics',
            activeBaseRegex: `/tutorials/`,
          },
          {
            html: '<span class="nav-emoji">📖</span> Solutions',
            to: '/solutions/category/0000---0099',
            activeBaseRegex: `/solutions/`,
          },
          {
            html: '<span class="nav-emoji">🏷️</span> Tags',
            to: '/solutions/tags/',
            activeBaseRegex: `/solutions/tags/`,
          },
          {
            html: '<span class="nav-emoji">🏛️</span> Roadmap',
            to: '/roadmap/',
            activeBaseRegex: `/roadmap/`,
          },
          {
            html: '<span class="nav-emoji">🖥️</span> Templates',
            to: '/templates/',
            activeBaseRegex: `/templates/`,
          },
          // {to: '/blog', label: 'Blog', position: 'left'},
          {
            href: 'https://github.com/wingkwong/leetcode-the-hard-way',
            position: 'right',
            className: 'header-github-link',
            'aria-label': 'GitHub repository',
          },
          {
            href: 'https://discord.com/invite/Nqm4jJcyBf',
            position: 'right',
            className: 'navbar-icon',
            'aria-label': 'Discord channel',
            html: `<svg stroke="currentColor" fill="currentColor" stroke-width="0" viewBox="0 0 640 512" height="24" width="24" xmlns="http://www.w3.org/2000/svg"><path d="M524.531,69.836a1.5,1.5,0,0,0-.764-.7A485.065,485.065,0,0,0,404.081,32.03a1.816,1.816,0,0,0-1.923.91,337.461,337.461,0,0,0-14.9,30.6,447.848,447.848,0,0,0-134.426,0,309.541,309.541,0,0,0-15.135-30.6,1.89,1.89,0,0,0-1.924-.91A483.689,483.689,0,0,0,116.085,69.137a1.712,1.712,0,0,0-.788.676C39.068,183.651,18.186,294.69,28.43,404.354a2.016,2.016,0,0,0,.765,1.375A487.666,487.666,0,0,0,176.02,479.918a1.9,1.9,0,0,0,2.063-.676A348.2,348.2,0,0,0,208.12,430.4a1.86,1.86,0,0,0-1.019-2.588,321.173,321.173,0,0,1-45.868-21.853,1.885,1.885,0,0,1-.185-3.126c3.082-2.309,6.166-4.711,9.109-7.137a1.819,1.819,0,0,1,1.9-.256c96.229,43.917,200.41,43.917,295.5,0a1.812,1.812,0,0,1,1.924.233c2.944,2.426,6.027,4.851,9.132,7.16a1.884,1.884,0,0,1-.162,3.126,301.407,301.407,0,0,1-45.89,21.83,1.875,1.875,0,0,0-1,2.611,391.055,391.055,0,0,0,30.014,48.815,1.864,1.864,0,0,0,2.063.7A486.048,486.048,0,0,0,610.7,405.729a1.882,1.882,0,0,0,.765-1.352C623.729,277.594,590.933,167.465,524.531,69.836ZM222.491,337.58c-28.972,0-52.844-26.587-52.844-59.239S193.056,219.1,222.491,219.1c29.665,0,53.306,26.82,52.843,59.239C275.334,310.993,251.924,337.58,222.491,337.58Zm195.38,0c-28.971,0-52.843-26.587-52.843-59.239S388.437,219.1,417.871,219.1c29.667,0,53.307,26.82,52.844,59.239C470.715,310.993,447.538,337.58,417.871,337.58Z"></path></svg>`,
          },
          {
            href: 'https://www.youtube.com/@leetcodethehardway?sub_confirmation=1',
            position: 'right',
            className: 'navbar-icon',
            'aria-label': 'YouTube channel',
            html: `<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" fill="currentColor" viewBox="0 0 16 16">
                    <path d="M8.051 1.999h.089c.822.003 4.987.033 6.11.335a2.01 2.01 0 0 1 1.415 1.42c.101.38.172.883.22 1.402l.01.104.022.26.008.104c.065.914.073 1.77.074 1.957v.075c-.001.194-.01 1.108-.082 2.06l-.008.105-.009.104c-.05.572-.124 1.14-.235 1.558a2.007 2.007 0 0 1-1.415 1.42c-1.16.312-5.569.334-6.18.335h-.142c-.309 0-1.587-.006-2.927-.052l-.17-.006-.087-.004-.171-.007-.171-.007c-1.11-.049-2.167-.128-2.654-.26a2.007 2.007 0 0 1-1.415-1.419c-.111-.417-.185-.986-.235-1.558L.09 9.82l-.008-.104A31.4 31.4 0 0 1 0 7.68v-.123c.002-.215.01-.958.064-1.778l.007-.103.003-.052.008-.104.022-.26.01-.104c.048-.519.119-1.023.22-1.402a2.007 2.007 0 0 1 1.415-1.42c.487-.13 1.544-.21 2.654-.26l.17-.007.172-.006.086-.003.171-.007A99.788 99.788 0 0 1 7.858 2h.193zM6.4 5.209v4.818l4.157-2.408L6.4 5.209z"/>
                  </svg>`,
          },
        ],

and css

@media screen and (min-width: 1000px) and (max-width: 1119px) {
  .nav-emoji{
    display: none;
  }
}

ajay-dhangar

All is okay to my side can you review and give me your response.

docusaurus.config.js

ajay-dhangar · 2023-10-04T02:57:33Z

can you check out

wingkwong

You should always verify it first.

src/css/custom.css

ajay-dhangar · 2023-10-04T09:31:25Z

please remove those unused icon images.

I removed those unused icon images.

ajay-dhangar · 2023-10-04T10:01:11Z

You should always verify it first.

Size (997px - 1119px)

Size (1120px)

Size (996px)

wingkwong

please fix this as well.

wingkwong · 2023-10-04T10:09:37Z

src/css/custom.css

+
+/*  for emoji's */
+
+@media screen and (min-width: 997px) and (max-width: 1119px) {


like I said before. don't use between and max-width. Please follow mobile first principle. (i.e. by default no emoji is shown, then show only when min-width is 1200px.

okay, I understand, I do to resolve this.

Not resolved at all...

ajay-dhangar

Completed For AnnoucementBar

ajay-dhangar · 2023-10-07T00:25:06Z

Can you review now,

wingkwong · 2023-10-07T05:29:43Z

src/css/custom.css

+
+/*  for emoji's */
+
+@media screen and (min-width: 997px) and (max-width: 1119px) {


Not resolved at all...

ajay-dhangar

Now, Check it only for min-width (❌ max-width).

src/css/custom.css

ajay-dhangar

New Conversation for PR...

wingkwong

Final round of changes. After that it's ready for the merge.

src/css/custom.css

ajay-dhangar

...

src/css/custom.css

ajay-dhangar

done my side and can you view any mistake then say me.

julix-unity · 2024-10-28T04:56:12Z

Sorry for commenting on resolved thing, but this was fun to read! Great job being patient, wingkwong and ajay stuck with it and got it done eventually.

And look at you now! @ajay-dhangar - your profile is wild. Don't think I've ever seen one so jam packed with accomplishments etc. - I'm still new to open source, your sticking-with-it is inspiring. The batch of daily medals too. I didn't even know they were a thing, maybe I'll give that a try.

ajay-dhangar added 3 commits October 2, 2023 17:23

new commit for footer and navbar

7f19792

new commit for footer and navbar

6cb042d

new commit for footer and navbar

cb93cd6

ajay-dhangar commented Oct 2, 2023

View reviewed changes

wingkwong reviewed Oct 2, 2023

View reviewed changes

new commit for footer and navbar

9f01c67

ajay-dhangar commented Oct 2, 2023

View reviewed changes

wingkwong requested changes Oct 2, 2023

View reviewed changes

Update docusaurus.config.js

603a697

ajay-dhangar commented Oct 3, 2023

View reviewed changes

new commit for navbar

225024b

ajay-dhangar commented Oct 3, 2023

View reviewed changes

new commit for navbar

8c0e3f3

wingkwong requested changes Oct 3, 2023

View reviewed changes

docusaurus.config.js Outdated Show resolved Hide resolved

ajay-dhangar commented Oct 3, 2023

View reviewed changes

new commit for navbar

b0316d7

ajay-dhangar commented Oct 3, 2023

View reviewed changes

docusaurus.config.js Outdated Show resolved Hide resolved

wingkwong requested changes Oct 4, 2023

View reviewed changes

src/css/custom.css Outdated Show resolved Hide resolved

new updates

f30fc6a

wingkwong reviewed Oct 4, 2023

View reviewed changes

new commit for navbar

11d8705

ajay-dhangar commented Oct 6, 2023

View reviewed changes

ajay-dhangar requested a review from wingkwong October 7, 2023 00:25

wingkwong requested changes Oct 7, 2023

View reviewed changes

src/css/custom.css Outdated

/* for emoji's */

@media screen and (min-width: 997px) and (max-width: 1119px) {

Copy link

Owner

wingkwong Oct 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not resolved at all...

new for responsive navbar

ff3272f

ajay-dhangar commented Oct 7, 2023

View reviewed changes

src/css/custom.css Outdated Show resolved Hide resolved

ajay-dhangar requested a review from wingkwong October 7, 2023 09:50

wingkwong requested changes Oct 7, 2023

View reviewed changes

src/css/custom.css Outdated Show resolved Hide resolved

new for responsive navbar

e93f02b

ajay-dhangar commented Oct 7, 2023

View reviewed changes

src/css/custom.css Outdated Show resolved Hide resolved

src/css/custom.css Show resolved Hide resolved

ajay-dhangar commented Oct 7, 2023

View reviewed changes

wingkwong requested changes Oct 7, 2023

View reviewed changes

src/css/custom.css Outdated Show resolved Hide resolved

src/css/custom.css Outdated Show resolved Hide resolved

src/css/custom.css Outdated Show resolved Hide resolved

ajay-dhangar added 2 commits October 7, 2023 22:05

new for responsive navbar

5ba6a5b

new for responsive navbar

11a6a60

ajay-dhangar commented Oct 7, 2023

View reviewed changes

ajay-dhangar requested a review from wingkwong October 7, 2023 16:46

wingkwong requested changes Oct 8, 2023

View reviewed changes

src/css/custom.css Outdated Show resolved Hide resolved

src/css/custom.css Show resolved Hide resolved

src/css/custom.css Outdated Show resolved Hide resolved

new for responsive navbar

108c760

ajay-dhangar requested a review from wingkwong October 8, 2023 10:30

ajay-dhangar commented Oct 8, 2023

View reviewed changes

wingkwong approved these changes Oct 8, 2023

View reviewed changes

wingkwong merged commit e8c72d9 into wingkwong:main Oct 8, 2023

wingkwong mentioned this pull request Oct 8, 2023

Adding Footer and Front-End Improvements #652

Closed


		/* for emoji's */

		@media screen and (min-width: 997px) and (max-width: 1119px) {

Uh oh!

Adding Footer and Front-End Improvements #655

Adding Footer and Front-End Improvements #655

Uh oh!

Conversation

ajay-dhangar commented Oct 2, 2023 • edited by wingkwong Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Change Summary

Checklist

General

Tutorial

Solutions

Uh oh!

ajay-dhangar left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wingkwong left a comment

Choose a reason for hiding this comment

Uh oh!

ajay-dhangar left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wingkwong left a comment

Choose a reason for hiding this comment

Uh oh!

ajay-dhangar left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wingkwong commented Oct 3, 2023

Uh oh!

ajay-dhangar left a comment

Choose a reason for hiding this comment

Uh oh!

wingkwong left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ajay-dhangar left a comment

Choose a reason for hiding this comment

Uh oh!

ajay-dhangar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ajay-dhangar commented Oct 4, 2023

Uh oh!

wingkwong left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ajay-dhangar commented Oct 4, 2023

Uh oh!

ajay-dhangar commented Oct 4, 2023

Uh oh!

wingkwong left a comment

Choose a reason for hiding this comment

Uh oh!

wingkwong Oct 4, 2023

Choose a reason for hiding this comment

Uh oh!

ajay-dhangar Oct 4, 2023

Choose a reason for hiding this comment

Uh oh!

wingkwong Oct 7, 2023

Choose a reason for hiding this comment

Uh oh!

ajay-dhangar left a comment

Choose a reason for hiding this comment

Uh oh!

ajay-dhangar commented Oct 7, 2023

Uh oh!

wingkwong Oct 7, 2023

Choose a reason for hiding this comment

Uh oh!

ajay-dhangar left a comment

Choose a reason for hiding this comment

Uh oh!

ajay-dhangar commented Oct 2, 2023 •

edited by wingkwong

Loading

ajay-dhangar left a comment •

edited

Loading

ajay-dhangar left a comment •

edited

Loading

ajay-dhangar left a comment •

edited

Loading