Skip to content

Commit

Permalink
Use internal compiler. Remove some fixed TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
aslakhellesoy committed Jan 2, 2012
1 parent 75ae79d commit 092c925
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 16 deletions.
15 changes: 0 additions & 15 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,18 +141,3 @@ Fork the repository on Github, clone it and send a pull request when you have fi

* Reports exception when Before hook fails
* Skips steps when before hook fails

Need to sort out path issues:

With Java we typically pick up duplicate features from src/test/resources and target/test-classes. This happens
because the absence of a @Feature tag defaults to ".", which is the current directory. Maybe the Backend needs
to tell whether to load features from the CLASSPATH or from the FS? It makes sense to use the CLASSPATH for Java
(and not the FS), but for dynamic languages it makes more sense to get them from the FS.

Also need to distinguish properly between gluePaths and featurePaths. This is a problem in the JUnit runner (Cucumber.java),
which currently picks it up from a system property.

Never use packages
The Test file's package is the dir
Can be overridden
Gluepath overridden separately
2 changes: 1 addition & 1 deletion cucumber-jvm.ipr
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
<option name="ADDITIONAL_OPTIONS_STRING" value="-target 1.6 -source 1.6 -encoding UTF-8" />
</component>
<component name="CompilerConfiguration">
<option name="DEFAULT_COMPILER" value="Javac" />
<option name="DEFAULT_COMPILER" value="compAPI" />
<resourceExtensions />
<wildcardResourcePatterns>
<entry name="?*.properties" />
Expand Down
1 change: 1 addition & 0 deletions java/src/main/code_generator/I18n.java.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package cucumber.annotation.<%= i18n.underscored_iso_code -%>;

import cucumber.runtime.java.StepDefAnnotation;

import java.lang.annotation.ElementType;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
Expand Down

0 comments on commit 092c925

Please sign in to comment.