Skip to content

Two dead parallel models read like real schema: Configuration.cs and CatalogItem.cs #161

Description

@rodchristiansen

Two types in shared/core/Models look authoritative and are referenced by nothing:

  • Configuration.cs is a complete snake_case client-configuration model. The real one is CimianConfig in cli/managedsoftwareupdate/Models/UpdateModels.cs:9, and it is PascalCase. build/msi/config.yaml is a matching snake_case sample that no build script packages, so it reinforces the wrong shape.
  • CatalogItem.cs declares keys the client never deserialises — url, installer_args, requires_elevation, restart_required, metadata.

Anyone reading the source to answer "what keys are supported" will find the wrong answer first, and a config written against Configuration.cs silently does nothing. Removing both (and the orphan sample) would leave one obvious answer.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions