Skip to content

installer_timeout is seconds, but the model documents it as minutes #159

Description

@rodchristiansen

installer_timeout (shared/core/Models/CatalogItem.cs:156) carries a comment describing the value as minutes. The engine treats it as seconds.

Anyone who writes installer_timeout: 30 intending half an hour gets thirty seconds, and a long installer is killed mid-write. Fixing the comment is the minimum; naming the unit in the pkgsinfo documentation would help more.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdocumentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions