-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🚧 add postgres trigger captures #5165
Open
dieriba
wants to merge
11
commits into
main
Choose a base branch
from
feat/postgres-trigger-captures
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,353
−347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying windmill with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 0ee9f7d in 1 minute and 17 seconds
More details
- Looked at
2605
lines of code in36
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_pPv4ikDsvJdSRfyG
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
dieriba
changed the title
feat: 🚧 add postgres trigger config in back
feat: 🚧 add postgres trigger captures
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add support for PostgreSQL triggers in backend and frontend, including configuration, management, and testing capabilities.
capture.rs
,http_triggers.rs
,postgres_triggers/handler.rs
,postgres_triggers/mod.rs
, andpostgres_triggers/trigger.rs
.PostgresTriggerConfig
and related structs for configuration.CaptureWrapper.svelte
,PostgresEditorConfigSection.svelte
,PostgresTriggerEditor.svelte
, andPostgresTriggersPanel.svelte
.CaptureButton.svelte
,TestTriggerConnection.svelte
, andTriggersEditor.svelte
.triggers.ts
to include PostgreSQL as a trigger kind.This description was created by for 0ee9f7d. It will automatically update as commits are pushed.