wmill cli flow push - avoid hardcoded suffix

[cherusk]

File path shall be file as denoted in cli docs. Hardcoded suffix counter productive.

---

Important

Remove hardcoded suffix from localPath in pushFlow() in flow.ts to align with CLI documentation.

• Behavior:
  • In pushFlow() in flow.ts, removed hardcoded suffix from localPath when parsing YAML file, allowing file path to be used as specified in CLI documentation.

^{This description was created by for 4882720. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 4882720 in 9 seconds

More details

• Looked at 13 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. cli/flow.ts:92

• Draft comment:
  Ensure localPath includes the filename, as the hardcoded 'flow.yaml' suffix was removed. This change assumes localPath is a complete file path, which might not always be the case.
• Reason this comment was not posted:
  Comment did not seem useful.

Workflow ID: wflow_Nhtxx2FVd2pzKorx

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[rubenfiszel]

It should not break previous behavior so at very least, it should try both location (previous and new one)

[cherusk]

FWIW I would argue this is a bug fix and not a breaking change to the cli API. It was never congruent with the cli API ...

[rubenfiszel]

It might be a bugfix but the behavior has been like this for so-long that we would want to not break existing users relying on the actual current behavior. Keeping compatibility for both is very little code complexity so it is worth it.

[cherusk]

ACK. My ts caps are limited, but I changed it to your suggestion.

With precedence on specific file path to config file.

[cherusk]

I have read the CLA Document and I hereby sign the CLA

[rubenfiszel]

Actually the correct way to do this would be to change the push function (the frontend for wmill flow push) rather than pushFlow which is used elsewhere internally.
You can do the opposite there and remove flow.yaml from the file path provided if it exists

[cherusk]

Ok, I have worked around it for now on my end.

I might look at this later as it is not urgent for me. Anyone feel free to adjust the PR or turn it into a issue if worth it ...