Skip to content

Refactor/leveldb getters #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 9, 2022
Merged

Refactor/leveldb getters #59

merged 8 commits into from
Jun 9, 2022

Conversation

@kostysh
Copy link
Contributor

@kostysh kostysh commented Jun 9, 2022 •
edited
Loading

closes #55

  • All getters now return value or null
  • associated code is refactored, and tests are working
  • getters that can return a combined type of value such as DayOfWeekRateModifier | OccupancyRateModifier | LOSRateModifier now accept the specification of the return type. Here is an example:
losModifier = await modifiers.getModifier<LOSRateModifier>(
  'length_of_stay'
);

kostysh added 6 commits June 9, 2022 11:42
@kostysh
chore: 🤖 Updated dependencies versions
faa77f8
@kostysh
refactor: 💡 Getters FacilityRepository.getFacilitKey/getItemKey
adb8aca 
these getters are now returns null if value not found

✅ Closes: #55
@kostysh
refactor: 💡 Getter ModifierRepository.getModifier
64c4d5f 
this getter now can return null if modifier not found

✅ Closes: #55
@kostysh
refactor: 💡 RuleRepository.getRule; SearchService.getRule
b46e1c4 
✅ Closes: #55
@kostysh
refactor: 💡 SpaceAvailabilityRepository.getSpaceAvailability
2b542d9 
now able to return null if availability not found

✅ Closes: #55
@kostysh
refactor: 💡 ItemRateRepository.getRate
ce1faf3 
now can return null if rate not found

✅ Closes: #55
@kostysh kostysh added D-easy Difficulty: easy P-normal Priority: normal T-debt Type: code debt C-database Components: database labels Jun 9, 2022
@kostysh kostysh self-assigned this Jun 9, 2022
@kostysh kostysh marked this pull request as ready for review June 9, 2022 12:59
@kostysh kostysh requested review from Galeaf11 and mfw78 June 9, 2022 13:00
@mfw78 mfw78 added this to the ETHBarcelona & ETHcc milestone Jun 9, 2022
mfw78
mfw78 approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@mfw78 mfw78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor is good. Minor suggestions on variable names in QuoteService.

@kostysh kostysh merged commit 0d83aaf into develop Jun 9, 2022
@kostysh kostysh deleted the refactor/leveldb-getters branch June 9, 2022 20:20
@mfw78 mfw78 linked an issue Jun 9, 2022 that may be closed by this pull request
Repositories getters refactoring #55
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Galeaf11 Galeaf11 Awaiting requested review from Galeaf11

1 more reviewer

@mfw78 mfw78 mfw78 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kostysh kostysh

Labels

C-database Components: database D-easy Difficulty: easy P-normal Priority: normal T-debt Type: code debt

Projects

None yet

Milestone

ETHBarcelona & ETHcc

Development

Successfully merging this pull request may close these issues.

Repositories getters refactoring

2 participants

@kostysh @mfw78