Skip to content

Feat/quote service #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 8, 2022
Merged

Feat/quote service #50

merged 7 commits into from
Jun 8, 2022

Conversation

@kostysh
Copy link
Contributor

@kostysh kostysh commented Jun 7, 2022 •
edited
Loading

This PR adds:

  • an implementation of the QuoteService
  • tests

@kostysh kostysh added D-average Difficulty: average P-high Priority: high T-feature Type: feature C-database Components: database labels Jun 7, 2022
@kostysh kostysh self-assigned this Jun 7, 2022
@mfw78 mfw78 added this to the ETHBarcelona & ETHcc milestone Jun 8, 2022
This was linked to issues Jun 8, 2022
feat: rate modifiers and rules #26
Closed
Implementation of rate modifiers (QuoteService) #46
Closed
mfw78
mfw78 reviewed Jun 8, 2022
View reviewed changes
@kostysh kostysh marked this pull request as ready for review June 8, 2022 15:41
@kostysh kostysh requested a review from mfw78 June 8, 2022 15:42
mfw78
mfw78 approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@mfw78 mfw78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mfw78
Copy link
Contributor

mfw78 commented Jun 8, 2022 •
edited
Loading

@kostysh Before merging, can you please address / confirm that the 'todo' in the PR description is complete?

@kostysh
Copy link
Contributor Author

kostysh commented Jun 8, 2022

All points from TODO have been done.

@kostysh kostysh merged commit 978c95e into develop Jun 8, 2022
kostysh added a commit that referenced this pull request Jun 8, 2022
@kostysh
refactor: 💡 Using Condition enum instead of raw valuew
849c109 
#50 (comment)
@kostysh kostysh deleted the feat/quote-service branch June 8, 2022 16:06
@mfw78 mfw78 linked an issue Jun 10, 2022 that may be closed by this pull request
Implementation of rules logic (SearchService) #45
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mfw78 mfw78 mfw78 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kostysh kostysh

Labels

C-database Components: database D-average Difficulty: average P-high Priority: high T-feature Type: feature

Projects

None yet

Milestone

ETHBarcelona & ETHcc

Development

Successfully merging this pull request may close these issues.

Implementation of rate modifiers (QuoteService) Implementation of rules logic (SearchService) feat: rate modifiers and rules

2 participants

@kostysh @mfw78