Skip to content

feat: 🎸 Added QuoteService interface #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2022
Merged

feat: 🎸 Added QuoteService interface #42

merged 2 commits into from
Jun 7, 2022

Conversation

@kostysh
Copy link
Contributor

@kostysh kostysh commented Jun 7, 2022 •
edited
Loading

Interfaces for:

  • QuoteService
  • SearchService
  • AuctioneerService

@kostysh kostysh requested a review from mfw78 June 7, 2022 11:13
@kostysh kostysh self-assigned this Jun 7, 2022
@kostysh kostysh added D-easy Difficulty: easy P-high Priority: high T-feature Type: feature C-database Components: database labels Jun 7, 2022
mfw78
mfw78 approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@mfw78 mfw78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mfw78 mfw78 merged commit d3f5da2 into develop Jun 7, 2022
@mfw78 mfw78 added this to the ETHBarcelona & ETHcc milestone Jun 7, 2022
@mfw78 mfw78 deleted the feat/quote-interface branch June 7, 2022 11:59
@mfw78 mfw78 linked an issue Jun 10, 2022 that may be closed by this pull request
Implementation of rules logic (SearchService) #45
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mfw78 mfw78 mfw78 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kostysh kostysh

Labels

C-database Components: database D-easy Difficulty: easy P-high Priority: high T-feature Type: feature

Projects

None yet

Milestone

ETHBarcelona & ETHcc

Development

Successfully merging this pull request may close these issues.

Implementation of rules logic (SearchService)

2 participants

@kostysh @mfw78