Skip to content

Fix/level merge #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Feat/leveldb
merged 3 commits into from
Jun 7, 2022
Merged

Fix/level merge #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95ad317
fix: 🐛 Fixed repository.spec.ts error
kostysh Jun 7, 2022
a6fac56
fix: 🐛 Fixes for prettier warnings
kostysh Jun 7, 2022
64b9864
chore: 🤖 more prettier fixes
kostysh Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/repositories/ItemRateRepository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,19 @@ import ApiError from '../exceptions/ApiError';
import { AbstractSublevel } from 'abstract-level';
import { Rates } from '../proto/lpms';


abstract class ItemRateRepository {
protected dbService = DBService.getInstance();
protected db: AbstractSublevel<AbstractSublevel<AbstractSublevel<DBLevel, LevelDefaultTyping, string, FacilityValues>,
LevelDefaultTyping,
string,
FacilityItemValues>,
protected db: AbstractSublevel<
AbstractSublevel<
AbstractSublevel<DBLevel, LevelDefaultTyping, string, FacilityValues>,
LevelDefaultTyping,
string,
FacilityItemValues
>,
LevelDefaultTyping,
DefaultOrDateItemKey,
Rates>;
Rates
>;

protected constructor(
facilityId: string,
Expand All @@ -41,10 +44,7 @@ abstract class ItemRateRepository {
}
}

public async setRate(
key: FormattedDate,
value: Rates
): Promise<void> {
public async setRate(key: FormattedDate, value: Rates): Promise<void> {
await this.db.put(key, value);
}

Expand Down
2 changes: 1 addition & 1 deletion src/repositories/ModifierRepository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export class ItemModifierRepository extends ModifierRepository {
LevelDefaultTyping,
string,
FacilityItemValues
>,
>,
LevelDefaultTyping,
ModifiersKey,
ModifiersValues
Expand Down
9 changes: 6 additions & 3 deletions src/repositories/RuleRepository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import DBService, {
Rules,
RulesItemKey
} from '../services/DBService';
import { AbstractSublevel } from 'abstract-level';
import { AbstractSublevel } from 'abstract-level';

abstract class RuleRepository {
protected db;
Expand All @@ -33,7 +33,6 @@ abstract class RuleRepository {
}
}


abstract class ItemRuleRepository extends RuleRepository {
protected db: AbstractSublevel<
AbstractSublevel<
Expand All @@ -47,7 +46,11 @@ abstract class ItemRuleRepository extends RuleRepository {
Rules
>;

protected constructor(facilityId: string, indexKey: FacilityIndexKey, itemId: string) {
protected constructor(
facilityId: string,
indexKey: FacilityIndexKey,
itemId: string
) {
super();

this.db = this.dbService.getItemRulesDB(facilityId, indexKey, itemId);
Expand Down
2 changes: 1 addition & 1 deletion src/repositories/SpaceStubRepository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
import { AbstractSublevel } from 'abstract-level';
import { AbstractStubRepository } from './StubRepository';

export class SpaceStubRepository extends AbstractStubRepository{
export class SpaceStubRepository extends AbstractStubRepository {
protected db: AbstractSublevel<
AbstractSublevel<
AbstractSublevel<DBLevel, LevelDefaultTyping, string, FacilityValues>,
Expand Down
2 changes: 1 addition & 1 deletion src/repositories/StubRepository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export abstract class AbstractStubRepository {
}
}

export class StubRepository extends AbstractStubRepository{
export class StubRepository extends AbstractStubRepository {
protected db: AbstractSublevel<
AbstractSublevel<DBLevel, LevelDefaultTyping, string, FacilityValues>,
LevelDefaultTyping,
Expand Down
20 changes: 12 additions & 8 deletions test/repository.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
import { FacilityRuleRepository, SpaceRuleRepository } from '../src/repositories/RuleRepository';
import {
FacilityRuleRepository,
SpaceRuleRepository
} from '../src/repositories/RuleRepository';
import { NoticeRequiredRule, Rates } from '../src/proto/lpms';
import { expect } from 'chai';
import { SpaceRateRepository } from '../src/repositories/ItemRateRepository';
Expand All @@ -19,10 +22,12 @@ describe('facility repository rule test', async () => {
});

it('get rule', async () => {
const rule = await facilityRuleRepository.getRule('notice_required')as
NoticeRequiredRule;
const spaceRule = await spaceRuleRepository.getRule('notice_required') as
NoticeRequiredRule;
const rule = (await facilityRuleRepository.getRule(
'notice_required'
)) as NoticeRequiredRule;
const spaceRule = (await spaceRuleRepository.getRule(
'notice_required'
)) as NoticeRequiredRule;

expect(rule.numDays).to.be.equal(10);
expect(spaceRule.numDays).to.be.equal(10);
Expand All @@ -49,9 +54,8 @@ describe('repository rate test', async () => {

it('set rate', async () => {
const rate: Rates = {
cost: 100,
includedOccupancy: 100
}
cost: 100
};

await spaceRuleRepository.setRateDefault(rate);
});
Expand Down