Skip to content

Conversation

@kostysh
Copy link
Contributor

@kostysh kostysh commented Jun 2, 2022

This PR:

  • fixes not worked typescript build
  • updates some dependencies versions

@kostysh kostysh requested review from mfw78 and valera-rozuvan June 2, 2022 19:00
tsconfig.json Outdated
"./swagger"
],
"exclude": [
"node_modules"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed for some specific reason? Given that this is the default per https://www.typescriptlang.org/tsconfig#exclude

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • done

@mfw78 mfw78 added the D-average Difficulty: average label Jun 3, 2022
@mfw78 mfw78 added this to the ETHBarcelona milestone Jun 3, 2022
@mfw78
Copy link
Contributor

mfw78 commented Jun 3, 2022

@kostysh With respect to CI/CD testing, if these are related to environment variables, how about we use something like:

"test": "source .env.example && yarn test "

Or something like this. This way we can both:

  1. Be ensured that the .env.example that we are packaging is valid.
  2. Our test environment doesn't depend on GitHub CI/CD environment.

@mfw78 mfw78 merged commit 0f09537 into main Jun 3, 2022
@kostysh kostysh deleted the fix/ts-build branch June 3, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

D-average Difficulty: average

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants