Refactor SpaceAvailability #19
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This standards the storage of the Availability protobuf message. Particularly when being called, it just simply wraps the leveldb database. Functionally, this is required as a per day override may be used in order to 'ram' the availability of a space type to 0 when a guesthouse wants to 'block' out a specific space type for a day. BREAKING CHANGE: 🧨 Discrete daily override does NOT only increment numSpaces
Updates the storage schema to add missing rates for otherItems, as well as convering on standards for space and otherItems with respect to metadata keys. BREAKING CHANGE: 🧨 metadata keys for spaces are changed ✅ Closes: #13
kostysh
previously approved these changes
Jun 6, 2022
kostysh
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the space availability and sets it so that it just sets the object, there is no incrementing of `numSpaces.