Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Supermium build without Crashpad/Breakpad #915

Closed
ellegance opened this issue Sep 24, 2024 · 4 comments
Closed

Make Supermium build without Crashpad/Breakpad #915

ellegance opened this issue Sep 24, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@ellegance
Copy link

ellegance commented Sep 24, 2024

Is your feature request related to a problem? Please describe.
Every time Supermium started, it launches extra process of type crashpad-handler without any possibility to disable it. While it might be useful for someone, for majority of users it is not needed, disabling Crashpad will save RAM, threads and disk space used for hundreds of useless reports

Describe the solution you'd like
Make Supermium build without Crashpad

@ellegance ellegance added the enhancement New feature or request label Sep 24, 2024
@RamonUnch
Copy link

Is not --disable-breakpad enough for you?

@Vangelis66
Copy link

Is not --disable-breakpad enough for you?

This cmdline flag DOES NOT prevent Supermium from spawning the chrome.exe --type=crashpad-handler processes inside Windows Task Manager

https://codereview.chromium.org/1416133003

Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Crashpad is always compiled into chrome and its handler is always
enabled. It only uploads in Official builds.

On Windows, the crash handler is chrome.exe run with a
--crashpad-handler argument. This is due to concern about
incompatibilities of shipping an additional new different binary for AV,
firewalls, etc

https://chromium.googlesource.com/chromium/src/+/a8151cabb1331736da3b76effbf2b153b76ae78c/components/crash/content/app/crashpad.h

// On Windows, use InitializeCrashpadWithEmbeddedHandler() when crashpad_handler
// is embedded into a binary that can be launched with --type=crashpad-handler.

I have tested this myself, i.e. I launched Supermium with --disable-breakpad, but still inside WTM:

TM

Also, please read this and this; even with --disable-crashpad-for-testing, I still get at least one crashpad-handler process spawned by Supermium 😞 ...

@win32ss
Copy link
Owner

win32ss commented Sep 26, 2024

Breakpad is the old exception handler for Chromium. It was replaced with Crashpad but Crashpad cannot be fully disabled in its current form (by the user).

But I can definitely disable the creation of Crashpad processes. Windows will handle the exceptions/errors on its own and Dr Watson (on XP) or WER (on Vista and up) can help provide the dumps as needed. Exception handling will not be as graceful, but it may better expose issues.

@Zero3K
Copy link

Zero3K commented Sep 26, 2024

That would be nice.

win32ss pushed a commit that referenced this issue Oct 2, 2024
@win32ss win32ss closed this as completed Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants