Add Cherry Studio package definition#1775
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Adding a new package involves custom logic for URL parsing and version extraction which should be verified by a human to ensure correctness and source legitimacy.
01-main/packages/cherry-studio
Outdated
| case ${HOST_ARCH} in | ||
| amd64) ARCH=amd64 ;; | ||
| arm64) ARCH=arm64 ;; | ||
| esac |
There was a problem hiding this comment.
This mapping seems superfluous. Why don't you just use HOST_ARCH directly below?
|
@snoack You are absolutely right. The mapping is unnecessary. I'll simplify it to directly use HOST_ARCH. |
Per review feedback from @snoack, removed unnecessary ARCH mapping. Closes wimpysworld#1775
|
The fix has been committed in the |
philclifford
left a comment
philclifford
left a comment
There was a problem hiding this comment.
Please note the reason this fails CI test is that the packaged app is cherrystudio and the manifest entry and definition filename must exactly match the app name.
apt info ./Cherry-Studio-1.8.3-amd64.deb
Package: cherrystudio
| # No mapping needed - directly use HOST_ARCH | ||
| get_github_releases "CherryHQ/cherry-studio" "latest" | ||
| if [ "${ACTION}" != "prettylist" ]; then | ||
| URL=$(grep -m 1 "browser_download_url.*Cherry-Studio-.*-${HOST_ARCH}\\.deb\\\"" "${CACHE_FILE}" | cut -d'"' -f4) |
There was a problem hiding this comment.
| URL=$(grep -m 1 "browser_download_url.*Cherry-Studio-.*-${HOST_ARCH}\\.deb\\\"" "${CACHE_FILE}" | cut -d'"' -f4) | |
| URL=$(grep -m 1 "browser_download_url.*Cherry-Studio-.*-${HOST_ARCH}\\.deb\\\"" "${CACHE_FILE}" | cut -d '"' -f 4) |
| get_github_releases "CherryHQ/cherry-studio" "latest" | ||
| if [ "${ACTION}" != "prettylist" ]; then | ||
| URL=$(grep -m 1 "browser_download_url.*Cherry-Studio-.*-${HOST_ARCH}\\.deb\\\"" "${CACHE_FILE}" | cut -d'"' -f4) | ||
| VERSION_PUBLISHED=$(echo "${URL}" | cut -d'/' -f8 | tr -d v | cut -d'-' -f3) |
There was a problem hiding this comment.
| VERSION_PUBLISHED=$(echo "${URL}" | cut -d'/' -f8 | tr -d v | cut -d'-' -f3) | |
| VERSION_PUBLISHED=$(cut -d '/' -f 8 <<< "${URL//v/}" ) |
| caddy | ||
| caprine | ||
| #cawbird | ||
| cherry-studio |
There was a problem hiding this comment.
| cherry-studio | |
| cherrystudio |
3 participants
Summary
01-main/packages/cherry-studiodefinition for Cherry Studioamd64andarm64by selecting matching.debassets from GitHub Releasescherry-studioto01-main/manifestCloses #1753