Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing fixes #27

Merged
merged 12 commits into from
Feb 4, 2024
Merged

Typing fixes #27

merged 12 commits into from
Feb 4, 2024

Conversation

palfrey
Copy link
Contributor

@palfrey palfrey commented Feb 2, 2024

Fixes #15.

Also

  • Upgrades minimum Python to 3.7 and sets structlog requirement so we have typing support there.

@palfrey palfrey marked this pull request as ready for review February 2, 2024 19:58
@wimglenn
Copy link
Owner

wimglenn commented Feb 2, 2024

Is there a point of type-hinting in the tests/*.py? IIUC users would only be interesting in typing of the plugin itself.

@palfrey
Copy link
Contributor Author

palfrey commented Feb 3, 2024

Is there a point of type-hinting in the tests/*.py? IIUC users would only be interesting in typing of the plugin itself.

Main reason for that is to act as a test case for the "check this works when someone installs it" i.e. the "pip install without -e" case, which already caught errors in 3d88415. Also a little bit of personal preference for typing tests as well for better IDE support.

@wimglenn wimglenn merged commit a52c50c into wimglenn:main Feb 4, 2024
2 checks passed
@palfrey palfrey deleted the typing-fixes branch February 4, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: type hinting / mypy support
2 participants