Readme and deployment #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bret-fears
commented
Mar 28, 2017
bret-fears
commented
- Add bintray deployment options for jcenter
- Include repo location for bintray in readme
bret-fears
force-pushed
the
feature/readme-update
branch
from
93f6a9a
to
4fba6b1
Compare
evant
reviewed
Mar 28, 2017
README.md
Outdated
| @@ -16,6 +16,12 @@ Spruce is a lightweight animation library that helps choreograph the animations | |||
| Add the following to your project's build.gradle file | |||
|
|
|||
| ``` | |||
| repositories { | |||
| maven { | |||
| url "http://willowtreeapps.bintray.com/maven2" | |||
There was a problem hiding this comment.
isn't jcenter() good enough?
There was a problem hiding this comment.
I thought so but... the setup had me create a repo which was a little weird.
There was a problem hiding this comment.
If jcenter doesn't work that kinda defeats the purpose of uploading it to bintray
lib/build.gradle
Outdated
| //Properties properties = new Properties() | ||
| //properties.load(project.rootProject.file('local.properties').newDataInputStream()) | ||
| // | ||
| //bintray { |
There was a problem hiding this comment.
it's pulling from local.properties which is ignored for configuration purposes. I'd rather it not be commented but I don't wanna have a stub local.properties either.
There was a problem hiding this comment.
why local.properties instead of putting it in your ~/.gradle/gradle.properties? You can just wrap with an if block that checks if the props exist.
bret-fears
force-pushed
the
feature/readme-update
branch
3 times, most recently
from
ea22c04
to
d6bc13d
Compare
evant
approved these changes
Mar 29, 2017
bret-fears
force-pushed
the
feature/readme-update
branch
from
e26d1db
to
c2ec732
Compare
- Add bintray deployment options for jcenter - Include repo location for bintray in readme
bret-fears
force-pushed
the
feature/readme-update
branch
from
c2ec732
to
0b2d02c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.