Recycler View Extensibility Test #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bret-fears
commented
Mar 23, 2017
bret-fears
commented
- Add RecyclerActivity
- Add RecyclerFragment
- Add Example recycler view
- Animate recycler children once they're layout is calculated
- Wire up options menu for both activities to allow users to navigate between them
- Add home option to Recycler for quickly navigating back to the sort example
evant
reviewed
Mar 23, 2017
| recyclerView = (RecyclerView) container.findViewById(R.id.recycler); | ||
| recyclerView.setHasFixedSize(true); | ||
|
|
||
| RelativeLayout placeHolder = (RelativeLayout) container.findViewById(R.id.placeholder_view); |
There was a problem hiding this comment.
minor, but placeholder is 1 word
|
Yeah this is fine, Ideally you'd bake in explicit recyclerview support but that can wait for a later version. |
- Add RecyclerActivity - Add RecyclerFragment - Add Example recycler view - Animate recycler children once they're layout is calculated - Wire up options menu for both activities to allow users to navigate between them - Add home option to Recycler for quickly navigating back to the sort example
bret-fears
force-pushed
the
feature/recycler-extensibility-test
branch
from
9faeebb
to
d72eeef
Compare
evant
approved these changes
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.