Repository navigation
fix: default display/unverified reads to include_proof:false - #10
Merged
Merged
Conversation
graphqlQuery() now sends include_proof:false on the POST body by default (previously omitted; the server defaults an absent flag to true, so display reads paid per-entity Merkle proving + the proof-consistency retry loop, ~22x bytes and 2-4x latency, then discarded the proof). Adds an includeProof opt-in on GraphQLQueryOptions. Verification APIs (verified query()/getData(), queryHistoricalVerified(), verifiable-rpc, eth-state) are unchanged and still fail closed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Plain display reads omitted
include_proof, and the server defaults an absent flag totrue— so every display read paid per-entity Merkle proving plus the proof-consistency retry loop (measured ~22× bytes, 2–4× latency on an idle indexer) and then discarded a proof it never verified. This sendsinclude_proof: falseexplicitly on the display read path.Verification APIs are untouched and still fail closed: verified
query()/getData(),queryHistoricalVerified(), verifiable-rpc and eth-state all still request and verify proofs.This repo
graphqlQuery()now setsinclude_proof: options?.includeProof ?? falseon the POST body (previously omitted the field entirely — mirrorssqlQuery(), which was already correct).GraphQLQueryOptionsgains anincludeProof?: booleanopt-in so callers can turn proofs back on.Verification
tsc --noEmitandnpm run buildclean;jest17/17 pass, including a newrouting.test.tscase asserting the serialized POST body carriesinclude_proof:falseby default andtruewhen opted in. No verification API changed.Closes the "SDK display reads: pass
include_proof: false" task.🤖 Generated with Claude Code