-
Couldn't load subscription status.
- Fork 18
Python27 #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Python27 #19
Conversation
ddex.ddex into ddex.__init__ Allowed for python 27 and python 3+ versions of tkinter to be imported Added an alternative method for mkdir -p 56 / 82 unit tests pass
unit tests 86/87
renamed database from ddexui to ddexui.db (conflict with directory name)
|
Hey, @traxair that looks really cool. TBH I took the opportunity of starting this project to teach myself python. I assumed it was best to start by learning python 3, but it seems that most of the community is still using python 2, so that may have been a mistake! It looks like there are a lot of line ending differences in the pull request, could you convert them to the same as the source line endings so that it's easier to see the edits? I'll try to run the tests on python 3 in the next few days. |
|
What line ending do you use? My setup is the eclipse / git default, so it should be CRLF |
|
BTW I can't find your email, could we chat about how this library could be made compatible for reading DDEX files as well? |
|
OK, Eclipse's default is CRLF, and then Git converts this to LF, which usually works fine with other repositories I participate in. LF is more "unix", so it would make sense to choose this one (who needs 2 newline characters?) |
Hello,
I wanted to test your module, but I mostly use python 27 so I've done a bit of work to make it compatible. Could you check if it works fine in python 3+?