Skip to content

Conversation

@flavianh
Copy link

Hello,

I wanted to test your module, but I mostly use python 27 so I've done a bit of work to make it compatible. Could you check if it works fine in python 3+?

Flavian added 8 commits January 18, 2015 14:35
ddex.ddex into ddex.__init__
Allowed for python 27 and python 3+ versions of tkinter to be imported
Added an alternative method for mkdir -p
56 / 82 unit tests pass
unit tests 86/87
renamed database from ddexui to ddexui.db (conflict with directory name)
@willm
Copy link
Owner

willm commented Jan 18, 2015

Hey, @traxair that looks really cool. TBH I took the opportunity of starting this project to teach myself python. I assumed it was best to start by learning python 3, but it seems that most of the community is still using python 2, so that may have been a mistake!

It looks like there are a lot of line ending differences in the pull request, could you convert them to the same as the source line endings so that it's easier to see the edits? I'll try to run the tests on python 3 in the next few days.

@flavianh
Copy link
Author

What line ending do you use? My setup is the eclipse / git default, so it should be CRLF

@flavianh
Copy link
Author

BTW I can't find your email, could we chat about how this library could be made compatible for reading DDEX files as well?

@flavianh
Copy link
Author

OK, Eclipse's default is CRLF, and then Git converts this to LF, which usually works fine with other repositories I participate in. LF is more "unix", so it would make sense to choose this one (who needs 2 newline characters?)

@willm willm self-assigned this Jan 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants