Use attribute fallthrough instead of comment

avr-gcc picks it up anyways
willietc · Jan 15, 2020 · 80f771f · 80f771f
1 parent 3be80b6
commit 80f771f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/avr/libraries/Wire/src/utility/twi.c b/avr/libraries/Wire/src/utility/twi.c
@@ -444,7 +444,8 @@ ISR(TWI_vect)
     // Master Receiver
     case TW_MR_DATA_ACK: // data received, ack sent
       // put byte into buffer
-      twi_masterBuffer[twi_masterBufferIndex++] = TWDR; // Fall through
+      twi_masterBuffer[twi_masterBufferIndex++] = TWDR;
+      __attribute__ ((fallthrough));
     case TW_MR_SLA_ACK:  // address sent, ack received
       // ack if more bytes are expected, otherwise nack
       if(twi_masterBufferIndex < twi_masterBufferLength){
@@ -531,7 +532,7 @@ ISR(TWI_vect)
         twi_txBuffer[0] = 0x00;
       }
       // transmit first byte from buffer, fall
-    // Fall through
+      __attribute__ ((fallthrough));
     case TW_ST_DATA_ACK: // byte sent, ack returned
       // copy data to output register
       TWDR = twi_txBuffer[twi_txBufferIndex++];

diff --git a/avr/libraries/Wire1/src/utility/twi1.c b/avr/libraries/Wire1/src/utility/twi1.c
@@ -445,7 +445,8 @@ ISR(TWI1_vect)
     // Master Receiver
     case TW_MR_DATA_ACK: // data received, ack sent
       // put byte into buffer
-      twi_masterBuffer[twi_masterBufferIndex++] = TWDR1; // Fall through
+      twi_masterBuffer[twi_masterBufferIndex++] = TWDR1;
+      __attribute__ ((fallthrough));
     case TW_MR_SLA_ACK:  // address sent, ack received
       // ack if more bytes are expected, otherwise nack
       if(twi_masterBufferIndex < twi_masterBufferLength){
@@ -532,7 +533,7 @@ ISR(TWI1_vect)
         twi_txBuffer[0] = 0x00;
       }
       // transmit first byte from buffer, fall
-    // Fall through
+      __attribute__ ((fallthrough));
     case TW_ST_DATA_ACK: // byte sent, ack returned
       // copy data to output register
       TWDR1 = twi_txBuffer[twi_txBufferIndex++];