Run Bathtub as a default sequence #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- modified: src/bathtub_pkg/bathtub.svh - New `as_sequence()` allows user to launch Bathtub as a sequence. - new file: src/bathtub_pkg/bathtub_sequence.svh - New `bathtub_sequence` class, when started, configures and runs given Bathtub object. - modified: src/bathtub_pkg/step_definition_interface.svh - modified: src/bathtub_pkg/step_static_attributes_interface.svh - Broke include recursion. - modified: test/conftest.py - New `uvm_version` `opts` attribute calculates special opts required for particular versions. - This makes it simpler for tests to iterate over versions; just use the `opts` attribute associated with every version. - modified: test/dependency_test.py - Added `bathtub_sequence`. - modified: test/e2e/basic/basic_test.py - To `test_basic_e2e` added new UVM tests for `bathtub_sequence`. - Cross the tests with every `uvm_version`. - That's many more crosses, so the test runs quite a bit longer now. - modified: test/e2e/basic/basic_tests.svh - New tests for `bathtub_sequence`. - new file: test/e2e/basic/tests/basic_sequence_start_test.svh - New test configures and runs Bathtub as a sequence with `start`. - new file: test/e2e/basic/tests/basic_sequence_test.svh - New test configures and runs Bathtub implicitly as a default sequence.
…iple test runs. - modified: test/conftest.py - `uvm_versions_from_config()` was not a fixture so it was delivering a static list of simulator objects. - Tests that used `uvm_version()` were getting the same simulator object each time they ran, requiring the object to be reset so that the arguments didn't accumulate. - Fixed this so that the fixture `uvm_version()` does the simulator object creation, so it's new for each test run. - modified: test/e2e/basic/basic_test.py - Simulator reset is not longer needed
- modified: src/bathtub_pkg/bathtub.svh - New docstring for `as_sequence()`. - modified: test/e2e/basic/tests/basic_sequence_test.svh - Changed run phase to main phase to match `basic_sequence_start_test()`.
- modified: src/bathtub_pkg/bathtub.svh - Indented docstrings. - Cleaned up indentation overall.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #119