ci(classify): treat all src/ projects + root build infra as risk:core#58
Merged
Conversation
isCore only matched `src/Caliber.Webhooks/` (trailing slash), so sibling provider projects (e.g. src/Caliber.Webhooks.EntityFrameworkCore/, added in #57) and the root build infra (Directory.Build.props/Directory.Packages.props — repo-wide deps and analyzers) fell through to risk:low. PR #57 had to be relabelled core by hand, and every M2 storage-provider PR would mis-classify the same way. Broaden isCore to the whole src/ tree plus the root build-props files. Critical still wins by precedence (public API / migrations / security source), and .github/workflows/** stays core. No behaviour change for the existing core lib or trivial-docs auto-merge. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
github-actions
Bot
added
the
risk:core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
classify.yml'sisCoreonly matchedp.startsWith('src/Caliber.Webhooks/')(trailing slash), so:src/Caliber.Webhooks.EntityFrameworkCore/(added in feat(storage): scaffold Caliber.Webhooks.EntityFrameworkCore (DbContext + schema) (S1 of #37) #57), and every future M2 storage provider — don't match and fall through torisk:low.Directory.Build.props/Directory.Packages.props(repo-wide dependency versions and analyzers, high blast radius) — also wasn't core.PR #57 had to be relabelled
risk:coreby hand. Without this, every M2src/provider PR mis-classifies the same way.Change
Broaden
isCoreto the wholesrc/tree plus the root build-props files:Precedence is unchanged:
criticalstill wins (public API / migrations / security source),.github/workflows/**stays core, and trivial-docs auto-merge is untouched. Header comment updated to match. No behaviour change for the existing core lib.risk:core(workflow change) — human review + merge.