Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding device selection support #9

Merged
merged 5 commits into from
Apr 3, 2018
Merged

Adding device selection support #9

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0385fb1
added support of device selection
Virgile-Dauge Mar 30, 2018
1486f4e
updated readme
Virgile-Dauge Mar 30, 2018
d1da438
updated readme for device feature
Virgile-Dauge Mar 30, 2018
3adde9d
formating to respect original author's format
Virgile-Dauge Mar 30, 2018
311cb52
fitting requested changes (device -> device_id) and (StereoCamera con…
Virgile-Dauge Apr 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
added support of device selection
  • Loading branch information
@Virgile-Dauge
Virgile-Dauge committed Mar 30, 2018
commit 0385fb144e75f150974c8bd22345886cbdeb36fa
2 changes: 2 additions & 0 deletions launch/zed_cpu_ros.launch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<launch>
<arg name="config_file_location" default="$(find zed_cpu_ros)/config/SN1267.conf"/>
<arg name="camera_namespace" default="camera"/>
<arg name="device" default="0"/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to device_id every where

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 311cb52 :)


<node pkg="zed_cpu_ros" type="zed_cpu_ros" name="zed_cpu_ros_node" output="screen" ns="$(arg camera_namespace)" required="true">
<param name="resolution" value="2"/>
Expand All @@ -10,6 +11,7 @@
<param name="left_frame_id" value="left_frame"/>
<param name="right_frame_id" value="right_frame"/>
<param name="load_zed_config" value="true"/>
<param name="device" value="$(arg device)"/>
</node>

<node pkg="tf" type="static_transform_publisher" name="static_tf_1" args="0.25 0 0.4 0 0 0 1 base_link left_frame 30"/>
Expand Down
Loading