Merged
Conversation
Contributor
Author
j/k the expected outputs were wrong |
bcardiff
approved these changes
Dec 3, 2024
Collaborator
bcardiff
left a comment
There was a problem hiding this comment.
Looks great.
Don't we also need a way to encode BigDecimal as a parameter?
Owner
|
Thanks @jgaskins ! Could you also please add a changelog item? |
Contributor
Author
For #295, absolutely. Until then, is the catch-all sufficient?
Sure thing! |
Contributor
Author
|
Just checking in, is there anything else this PR needs before merging? |
Owner
|
Oh whoops sorry about letting this sit for so long! I forgot to check back in. Thanks for bumping it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exploring using
decimalcolumns for storing currency values and representing them withBigDecimalvalues in Crystal code, but then noticedBigDecimalsupport hasn't made it into this shard yet. WhenPG::Numeric#to_big_rwas added, I don't thinkBigDecimalexisted in the Crystal stdlib.I copied most of the code from
to_big_r, but rather than building up a power of 10 for the second argument based on the placement of the decimal point, we can just use the placement of the decimal point itself.A couple of the tests are failing and I'm not sure how to fix them yet. They look like trivial ones, but I spent too long trying to figure out how BigDecimal` works and I'm out of gas for the evening.