Skip to content

Conversation

JcDai
Copy link
Collaborator

@JcDai JcDai commented Nov 8, 2023

add generic functions to extract a child mesh from a provided long-type tag (or its handle), and register the extracted child mesh to the parent mesh. (The child mesh should not break the orientation of the parent mesh)

  • extract child mesh by tag
  • extract child mesh by tag handle
  • generalize the functions
  • check if the orientation keeps in the childmesh

@JcDai JcDai added the draft label Nov 8, 2023
@JcDai JcDai changed the title extract child mesh from tag for trimesh extract child mesh from tag Nov 8, 2023
@JcDai JcDai linked an issue Nov 8, 2023 that may be closed by this pull request
@mtao mtao marked this pull request as draft November 8, 2023 20:28
Copy link
Collaborator Author

@JcDai JcDai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to check if the current implementation of filling the child mesh matrix (by simply switch vertex/edge from a ccw tuple) preserves the orientation for all possible cases.

@JcDai JcDai mentioned this pull request Nov 8, 2023
@JcDai JcDai removed the draft label Nov 9, 2023
@JcDai JcDai self-assigned this Nov 9, 2023
@JcDai JcDai marked this pull request as ready for review November 9, 2023 21:22
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (754f335) 85.46% compared to head (e49f1f8) 85.63%.
Report is 29 commits behind head on main.

Files Patch % Lines
...tk/multimesh/utils/extract_child_mesh_from_tag.cpp 95.38% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
+ Coverage   85.46%   85.63%   +0.16%     
==========================================
  Files         210      209       -1     
  Lines        5987     6159     +172     
==========================================
+ Hits         5117     5274     +157     
- Misses        870      885      +15     
Flag Coverage Δ
wildmeshing 85.63% <95.38%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mtao mtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly there. just deal with my comments

@mtao mtao mentioned this pull request Nov 9, 2023
@JcDai JcDai requested a review from mtao November 10, 2023 03:37
Copy link
Collaborator

@mtao mtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@daniel-zint daniel-zint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality is there. Just clean it up and you're good to go.

Please be a more careful about when to use which integer data type. int,long, and size_t are not the same thing.

@JcDai JcDai requested a review from daniel-zint November 14, 2023 22:19
Copy link
Contributor

@daniel-zint daniel-zint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JcDai JcDai merged commit 50987c0 into main Nov 15, 2023
@JcDai JcDai deleted the 501-extract_child_mesh_by_tag branch November 15, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

extract childmesh by tag

3 participants