-
Notifications
You must be signed in to change notification settings - Fork 20
extract child mesh from tag #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to check if the current implementation of filling the child mesh matrix (by simply switch vertex/edge from a ccw tuple) preserves the orientation for all possible cases.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #502 +/- ##
==========================================
+ Coverage 85.46% 85.63% +0.16%
==========================================
Files 210 209 -1
Lines 5987 6159 +172
==========================================
+ Hits 5117 5274 +157
- Misses 870 885 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly there. just deal with my comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functionality is there. Just clean it up and you're good to go.
Please be a more careful about when to use which integer data type. int
,long
, and size_t
are not the same thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
add generic functions to extract a child mesh from a provided long-type tag (or its handle), and register the extracted child mesh to the parent mesh. (The child mesh should not break the orientation of the parent mesh)