Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty assertion from er_io get_sources() and get_subjects() #240

Merged
merged 12 commits into from
Aug 14, 2024

Conversation

atmorling
Copy link
Contributor

closes #239

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 62.97%. Comparing base (55e989a) to head (25d5906).
Report is 9 commits behind head on master.

Files Patch % Lines
ecoscope/io/earthranger.py 0.00% 12 Missing ⚠️
ecoscope/io/async_earthranger.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #240       +/-   ##
===========================================
- Coverage   73.61%   62.97%   -10.64%     
===========================================
  Files          29       30        +1     
  Lines        2240     2304       +64     
===========================================
- Hits         1649     1451      -198     
- Misses        591      853      +262     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atmorling atmorling requested review from walljcg and Yun-Wu and removed request for walljcg August 5, 2024 14:30
Copy link
Collaborator

@walljcg walljcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex, this looks good.

@atmorling atmorling merged commit 3caa5e6 into wildlife-dynamics:master Aug 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove empty assertion from er_io get_sources() and get_subjects()
3 participants