Skip to content

Accept BigInt as input format#4

Open
dtamayo-nlp wants to merge 1 commit intowildart:masterfrom
dtamayo-nlp:new_branch
Open

Accept BigInt as input format#4
dtamayo-nlp wants to merge 1 commit intowildart:masterfrom
dtamayo-nlp:new_branch

Conversation

@dtamayo-nlp
Copy link
Copy Markdown

@dtamayo-nlp dtamayo-nlp commented Jan 2, 2023

Thank @wildart for driving this forward.

I only have a quick comment. I was testing this algorithm for big matrices and I found the necessity of using the BigInt format to avoid a "DivideError: integer division error" in line 12 of bezout.jl (click Issue for more information).

The problem was that this format is not accepted in your code because "there is no method matching typemax(::Type{BigInt})". I have adapted the use of "typemax" in one part of the code to accept it.

I hope you find it useful.

@thchr
Copy link
Copy Markdown

thchr commented Oct 18, 2024

It would be more meaningful to just change this to rsize = typemax(eltype(eachindex(M))), since the count below anyway will return something that references positions in the array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants