Let workflow 1 run on pull requests from forks - #100
Open
marvinm2 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workflow 1 runs on pull_request_target, and two of its jobs check out refs/pull/N/head. actions/checkout v6 refuses that, so both fail at their first step for any pull request from a fork. Same-repo pull requests are unaffected, which is why it has not come up before.
Changes:
I did not use allow-unsafe-pr-checkout. This workflow holds the deploy keys, and checking out fork code there is the risk the refusal exists to prevent.
Tested on a fork of the sandbox repo: run 30906919228, all ten jobs green on a real cross-repository pull request. A workflow_dispatch re-run does not test this, since it runs in the base context with a full token.