Add reading challenge translations#5822
Open
tonisevener wants to merge 26 commits intoreading-challengefrom
Open
Add reading challenge translations#5822tonisevener wants to merge 26 commits intoreading-challengefrom
tonisevener wants to merge 26 commits intoreading-challengefrom
Conversation
tonisevener
requested review from
a team and
l-olson1214
and removed request for
a team
l-olson1214
reviewed
Apr 23, 2026
|
|
||
|
|
||
| let defaultSubtitleAndGlobe: (String, String) = (WMFLocalizedString("reading-challenge-not-yet-read-subtitle-drift", value: "Don't let today drift by, save your streak.", comment: "Subtitle shown on the reading challenge widget when the user has not yet read today."), "sleepyglobe") | ||
| let defaultSubtitleAndGlobe: (String, String) = (WMFLocalizedString("reading-challenge-not-yet-read-subtitle-drift", value: "Don’t let today drift by, your reading streak is waiting.", comment: "Subtitle shown on the reading challenge widget when the user has not yet read today."), "sleepyglobe") |
Collaborator
There was a problem hiding this comment.
Do we have any concerns over the specific apostrophe being used? I see it changed it but I'm not sure if that's important
Collaborator
There was a problem hiding this comment.
I think that the one added is an accent since it leans forward. It won't cause parse errors (a backtick would), but it could be better for readability to maintain the single quote
l-olson1214
reviewed
Apr 23, 2026
| ), | ||
| value: "Join the challenge anytime between %1$@ and %2$@, complete your 25 days on your own timeline.", | ||
| comment: "Subtitle for reading challenge onboarding first item. %1$@ is a localized start day and month name, %2$@ is a localized end date and month name." | ||
| ), startText, endText), |
l-olson1214
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phabricator: https://phabricator.wikimedia.org/T421501
Notes
This manually adds widget localizations, plus commits a readme and prompt file for us to use in the future. This was mostly done through Copilot.
Since future manual translation spreadsheets will likely be formatted differently, I decided to have Copilot write and commit its own generic prompt instructions instead of a script for us to run. This way, Copilot can write whatever script it feels is best in-the-moment based on the translations we are trying to import.
Test Steps
(We can lean on QA for extensive testing)
Checklist
Screenshots/Videos