Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YiR dev settings #5016

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Add YiR dev settings #5016

merged 2 commits into from
Oct 10, 2024

Conversation

mazevedofs
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T376041 (partially)

Notes

  • Adds YiR dev settings
  • Not wired into any flows at the moment

Test Steps

  1. Go to dev settings, make sure you can see the toggle

@@ -0,0 +1,5 @@
import Foundation

final public class YearInReviewDataController {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mazevedofs I actually do want this empty class here, just in case we need to hook into it soon, thanks. Can you rename to WMFYearInReviewDataController?

@mazevedofs mazevedofs merged commit d00d095 into main Oct 10, 2024
4 checks passed
@mazevedofs mazevedofs deleted the add-dev-seetigs-yir branch October 10, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants