Make Pixel smarter about needed Codex version (WIP)#329
Open
montehurd wants to merge 3 commits intowikimedia:mainfrom
Open
Make Pixel smarter about needed Codex version (WIP)#329montehurd wants to merge 3 commits intowikimedia:mainfrom
montehurd wants to merge 3 commits intowikimedia:mainfrom
Conversation
montehurd
force-pushed
the
fix-codex-version
branch
from
498f356 to
b91e290
Compare
montehurd
changed the title
Collaborator
Author
|
I may have an issue - looking into it now... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this patch, if the user doesn't specify a Codex version to use via
--repo-branch, the version of Codex referenced in the MW branch in use is determined and usedNote: Couldn't use
git showto get the fileforeign-resources.yamlsince initially the MW repo isn't yet cloned. Can always tweak later. I hope to further consolidate all fetching in one place later, at which point we can probably re-visit this