Compose XML Color states #5232
Closed
Compose XML Color states #5232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- creates CircularButton component - creates OutlinedCircularButton - adds ThemeChooserButtons to settings theme chooser dialog for testing purpose
Williamrai
added
Experimental
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This implements custom buttons in Compose that can dynamically change their state without needing a separate function for XML selectors. In XML, we define colors for different states using selectors, but in Compose this can be handled directly within the button function itself. I also converted the theme buttons in the ThemeChooserDialog to Compose and limited the access to the AppTheme in settings for testing purpose.
Phabricator:
https://phabricator.wikimedia.org/T381832