feat: render ipypopout content in jupyter notebook and lab #805
+117
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenbreddels
force-pushed
the
feat_jupyter_ipypopout
branch
from
fa16d9c
to
fc612a9
Compare
maartenbreddels
force-pushed
the
feat_jupyter_ipypopout
branch
from
fc612a9
to
a4fae04
Compare
maartenbreddels
added a commit
to widgetti/ipypopout
that referenced
this pull request
Oct 2, 2024
Should be used in combination with: widgetti/solara#805
maartenbreddels
force-pushed
the
feat_jupyter_ipypopout
branch
from
a4fae04
to
7145c03
Compare
maartenbreddels
force-pushed
the
feat_jupyter_ipypopout
branch
from
7145c03
to
f931c6f
Compare
iisakkirotko
requested changes
Oct 8, 2024
| # tornado probably already does this, but just to be sure we don't serve files outside of the directory | ||
| # and that we are consistent with starlette and flask | ||
| if not path_is_child_of(Path(abspath), Path(self.root)): | ||
| raise PermissionError(f"Trying to read from outside of cache directory: {abspath} is not a subdir of {self.root}") |
There was a problem hiding this comment.
Wouldn't this still allow someone to find what files exist outside a given root directory? Not sure if that is problematic in this case.
solara/server/jupyter/solara.py
Outdated
| abspath = os.path.abspath(os.path.join(root, path)) | ||
| for root in self.roots[1:]: | ||
| abspath = os.path.abspath(os.path.join(root, path)) | ||
| # return early if someone tries to access a file outside of the directory |
There was a problem hiding this comment.
I don't think I follow what this comment is trying to say.
There was a problem hiding this comment.
Yes, that was a leftover comment, I'll remove it. Thanks
Instead of having to rely on voila to display widgets in a popout window, solara itself now can render it. This allows project to drop the dependency on voila.
maartenbreddels
force-pushed
the
feat_jupyter_ipypopout
branch
from
f931c6f
to
200fc2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having to rely on voila to display widgets in a popout window, solara itself now can render it. This allows project to drop the dependency on voila.