Ping fixes #75
Open
Ping fixes #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of ignoring it. Ignoring it resulted in some random following byte being interpreted as command.
… if no PONG is received for 90 seconds.
|
Uhh, do we have an alpha-site to test this? |
|
Unfortunately we don't have a test site for this. The best way to test it is to compile the servers yourself (small change required) and start them locally. To run them on the widelands server we would have to change the used port numbers in the game code and I would have to figure out how to start them on the server. |
|
Didn't test this, but the code looks good to me and not very dangerous. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bug fixes and changes to make the RTT display useful. See commit comments.
When deployed, this will break internet gaming for Widelands master until #4677 of Widelands is merged.