Skip to content

Commit

Permalink
more better logging
Browse files Browse the repository at this point in the history
  • Loading branch information
botsonfirst committed Sep 18, 2017
1 parent 579147f commit a320b46
Show file tree
Hide file tree
Showing 4 changed files with 30 additions and 11 deletions.
11 changes: 6 additions & 5 deletions cmd/wof-libpostal-server.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package main

import (
"flag"
"flag"
"fmt"
"github.com/facebookgo/grace/gracehttp"
"github.com/whosonfirst/go-whosonfirst-libpostal/http"
Expand All @@ -19,13 +19,13 @@ func main() {

logger := log.SimpleWOFLogger()

parser_handler, err := http.ParserHandler()
parser_handler, err := http.ParserHandler(logger)

if err != nil {
logger.Fatal("failed to create parser handler, because %v", err)
}

expand_handler, err := http.ExpandHandler()
expand_handler, err := http.ExpandHandler(logger)

if err != nil {
logger.Fatal("failed to create expand handler, because %v", err)
Expand All @@ -38,12 +38,13 @@ func main() {
}

endpoint := fmt.Sprintf("%s:%d", *host, *port)
logger.Status("listening on %s", endpoint)

mux := gohttp.NewServeMux()

mux.Handle("/parse", parser_handler)
mux.Handle("/expand", expand_handler)
mux.Handle("/ping", ping_handler)
mux.Handle("/ping", ping_handler)

err = gracehttp.Serve(&gohttp.Server{Addr: endpoint, Handler: mux})

Expand Down
11 changes: 10 additions & 1 deletion http/expand.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,12 @@ package http

import (
"github.com/openvenues/gopostal/expand"
"github.com/whosonfirst/go-whosonfirst-log"
gohttp "net/http"
"time"
)

func ExpandHandler() (gohttp.Handler, error) {
func ExpandHandler(logger *log.WOFLogger) (gohttp.Handler, error) {

fn := func(rsp gohttp.ResponseWriter, req *gohttp.Request) {

Expand All @@ -16,6 +18,13 @@ func ExpandHandler() (gohttp.Handler, error) {
return
}

t1 := time.Now()

defer func() {
t2 := time.Since(t1)
logger.Status("expand '%s' %v", address, t2)
}()

expansions := postal.ExpandAddress(address)
WriteResponse(rsp, expansions)
}
Expand Down
8 changes: 4 additions & 4 deletions http/expvar.go
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
package http

import (
"expvar"
"fmt"
gohttp "net/http"
"strings"
"expvar"
"fmt"
gohttp "net/http"
"strings"
)

var (
Expand Down
11 changes: 10 additions & 1 deletion http/parser.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,12 @@ package http

import (
"github.com/openvenues/gopostal/parser"
"github.com/whosonfirst/go-whosonfirst-log"
gohttp "net/http"
"time"
)

func ParserHandler() (gohttp.Handler, error) {
func ParserHandler(logger *log.WOFLogger) (gohttp.Handler, error) {

fn := func(rsp gohttp.ResponseWriter, req *gohttp.Request) {

Expand All @@ -16,6 +18,13 @@ func ParserHandler() (gohttp.Handler, error) {
return
}

t1 := time.Now()

defer func() {
t2 := time.Since(t1)
logger.Status("parse '%s' %v", address, t2)
}()

parsed := postal.ParseAddress(address)

query := req.URL.Query()
Expand Down

0 comments on commit a320b46

Please sign in to comment.