fix: Avoid double counting files and folders (#287) #356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@whoozle
Adding the directory to the files list is used to recurse into the subdirectories. The iterator flag QDirIterator::Subdirectories already does that automatically, so we only need to create the directory, not recurse into it.
This line wasn't in the initial implementation, instead was added later in 4b0a921. This PR is basically a revert of that commit. It's an easy mistake to make since the code looks recursive, but actually it's not. The recursion is handled implicitly by the iterator.
Resolves #287