Skip to content

Conversation

@Vekhir
Copy link

@Vekhir Vekhir commented Oct 13, 2025

@whoozle
Adding the directory to the files list is used to recurse into the subdirectories. The iterator flag QDirIterator::Subdirectories already does that automatically, so we only need to create the directory, not recurse into it.

This line wasn't in the initial implementation, instead was added later in 4b0a921. This PR is basically a revert of that commit. It's an easy mistake to make since the code looks recursive, but actually it's not. The recursion is handled implicitly by the iterator.

Resolves #287

Adding the directory to the files list is used to recurse into the subdirectories.
The iterator flag QDirIterator::Subdirectories already does that automatically, so we only need to create the directory, not recurse into it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sometimes directories uploading looped

1 participant