Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Rust 2021 #71

Merged
merged 8 commits into from
May 29, 2024
Merged

Upgrade to Rust 2021 #71

merged 8 commits into from
May 29, 2024

Conversation

TimTheBig
Copy link
Contributor

@TimTheBig TimTheBig commented May 27, 2024

Move to Rust 2021 and Refactor

Updates

Rust edition 2018 –> 2021
Version 2.5.2 –> 2.6.0
msrv according to cargo-msrv 1.40.0 –> 1.60.0, tested on x64 and arm64.

Small changes

Added "xdg" as keyword in cargo.toml
Add Swatinem/rust-cache to ci.yml and docs.yml for CI speed up.
Add CI, Doc-test, msrv and version badges to README.md.
actions/checkout v3 –> v4
Make lint workflow continue on fmt error, so clippy can also run.

@whitequark
Copy link
Owner

Thanks! It looks like clippy is still unhappy: https://github.com/TimTheBig/rust-xdg/actions/runs/9257836687/job/25466781313#step:6:22

@TimTheBig
Copy link
Contributor Author

TimTheBig commented May 27, 2024

The main clippy complaint does make the code a lot cleaner so I would consider it:

self.state_home.as_ref().map(|home| home.as_path()),
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using`self.state_home.as_deref()`

I can also make clippy ignore it with #[allow(clippy::option_as_ref_deref)] if you prefer.

@whitequark
Copy link
Owner

Yeah, let's apply that.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@whitequark whitequark merged commit 13e106c into whitequark:main May 29, 2024
3 checks passed
@whitequark
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants