Make getFastToc() fast again #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The data from itable may be more accurate, because ittoc comes from getFastToc(). Signed-off-by: Andreas Oberritter <obi@saftware.de>
Broken since whipper-team#345 was merged. Signed-off-by: Andreas Oberritter <obi@saftware.de>
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAICS, the fast TOC code-path served the following purposes:
Since #345 broke it, each rip ran the slow TOC code-path twice, resulting in needlessly slow rips and a useless caching mechanism.
This PR restores the previous behaviour.
The first commit just intends to make clear that data from the thorough TOC read is preferred over the data from fast TOC reads.
Please do not discuss whether slow TOC reads are useful here. It's a different issue. This is just a bug fix.