Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace sys.std{out,err} statements with logger/print calls #331

Merged
merged 2 commits into from
Dec 13, 2018
Merged

Replace sys.std{out,err} statements with logger/print calls #331

merged 2 commits into from
Dec 13, 2018

Conversation

JoeLametta
Copy link
Collaborator

@JoeLametta JoeLametta commented Nov 11, 2018 •
edited
Loading

Fixes #303.

@MerlijnWajer
Copy link
Collaborator

I would personally be in favour of using logging where you are currently using print() calls. Just turn them into debug level logging calls, or higher, if it makes sense.

@JoeLametta
Copy link
Collaborator Author

I would personally be in favour of using logging where you are currently using print() calls. Just turn them into debug level logging calls, or higher, if it makes sense.

Even things like these?

print('\nPicked requested release id %s' % release)
print('Artist: %s' % metadatas[0].artist.encode('utf-8'))
print('Title : %s' % metadatas[0].title.encode('utf-8'))

@JoeLametta JoeLametta force-pushed the feature/issue-303-use-standard-logging branch from 40035c1 to 2bd5f6a Compare November 13, 2018 16:14
@JoeLametta JoeLametta changed the title WIP: Issue 303 use standard logging WIP: Replace sys.std{out,err} statements with print/logger calls Nov 13, 2018
@JoeLametta JoeLametta force-pushed the feature/issue-303-use-standard-logging branch from 2bd5f6a to 0d0b45d Compare December 11, 2018 17:59
@JoeLametta JoeLametta force-pushed the feature/issue-303-use-standard-logging branch 4 times, most recently from 8d05250 to 9f707cc Compare December 12, 2018 18:33
@JoeLametta
Copy link
Collaborator Author

I think it is complete now...

@JoeLametta JoeLametta force-pushed the feature/issue-303-use-standard-logging branch from 9f707cc to eb39678 Compare December 13, 2018 19:06
@JoeLametta JoeLametta changed the title WIP: Replace sys.std{out,err} statements with print/logger calls WIP: Replace sys.std{out,err} statements with logger/print calls Dec 13, 2018
@JoeLametta JoeLametta changed the title WIP: Replace sys.std{out,err} statements with logger/print calls Replace sys.std{out,err} statements with logger/print calls Dec 13, 2018
@JoeLametta JoeLametta changed the title Replace sys.std{out,err} statements with logger/print calls WIP: Replace sys.std{out,err} statements with logger/print calls Dec 13, 2018
@JoeLametta
Change global default log level to 'INFO'
461728d 
We're going to increase our usage of logger statements instead of print instructions (where deemed opportune).
@JoeLametta
Replace sys.std{out,err} statements with logger/print calls
c7deccb 
Fixes #303.
@JoeLametta JoeLametta force-pushed the feature/issue-303-use-standard-logging branch from eb39678 to c7deccb Compare December 13, 2018 20:17
@JoeLametta JoeLametta changed the title WIP: Replace sys.std{out,err} statements with logger/print calls Replace sys.std{out,err} statements with logger/print calls Dec 13, 2018
@MerlijnWajer
Copy link
Collaborator

Looks good to me.

@JoeLametta JoeLametta merged commit c377417 into develop Dec 13, 2018
@JoeLametta JoeLametta deleted the feature/issue-303-use-standard-logging branch December 13, 2018 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Freso Freso Awaiting requested review from Freso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeLametta @MerlijnWajer