Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to group multi-disc releases in a single folder #448

Closed
the-confessor opened this issue Jan 11, 2020 · 3 comments · Fixed by #536
Closed

Ability to group multi-disc releases in a single folder #448

the-confessor opened this issue Jan 11, 2020 · 3 comments · Fixed by #536
Labels
Accepted Accepted issue on our roadmap Feature New feature Priority: low Low priority Sprintable Small enough to sprint on
Milestone

Comments

@the-confessor
Copy link

When I rip a multi-disc release I would like the content to all end up in a single folder.

It might be as simple as providing a couple more template options - the disc number, and the release title (i.e. the title of the release, not a title for the individual disc within the release).

e.g. let's us an example - Det bästa med Monica Zetterlund

Currently when I rip this with whipper I end up with two separate folders. (Limiting the examples to 1 file per folder)

Monica Zetterlund - Det bästa med Monica Zetterlund (Disc 1 of 2)/01 - Att angöra en brygga.flac
Monica Zetterlund - Det bästa med Monica Zetterlund (Disc 2 of 2)/01 - Bedårande sommarvals.flac

But I would rather see the discs contained in subfolders under one parent:

Monica Zetterlund - Det bästa med Monica Zetterlund/Disc 1/01 - Att angöra en brygga.flac
Monica Zetterlund - Det bästa med Monica Zetterlund/Disc 2/01 - Bedårande sommarvals.flac

Or potentially even all in one folder, using the file name to identify the disc:

Monica Zetterlund - Det bästa med Monica Zetterlund/D1 - 01 - Att angöra en brygga.flac
Monica Zetterlund - Det bästa med Monica Zetterlund/D2 - 01 - Bedårande sommarvals.flac

I think the additional template options would help me achieve this.

@JoeLametta JoeLametta added Accepted Accepted issue on our roadmap Feature New feature Priority: low Low priority labels Jan 14, 2020
@JoeLametta JoeLametta added this to the 2.0 milestone Jan 14, 2020
@JoeLametta JoeLametta added the Sprintable Small enough to sprint on label Jan 14, 2020
@JoeLametta
Copy link
Collaborator

I like this idea but keep in mind this is a low priority issue.

the release title (i.e. the title of the release, not a title for the individual disc within the release)

This specific request seems to be a duplicate of #440.

@the-confessor
Copy link
Author

the-confessor commented Jan 15, 2020

After digging into the code a bit I noticed that the release name with disc number is not directly from musicbrainz. Whipper has a hard coded behavior of combining the release title and disc number for multi-disc releases.

from mbngs.py:

                count = len(release['medium-list'])
                if count > 1:
                    title += ' (Disc %d of %d)' % (
                        int(medium['position']), count)

All I would need to achieve what I want is to have the disc number as a separate template and not automatically appended, so I can choose where it goes.

However realizing that some people may depend on the current behavior would make this an interesting change to roll out. The choice to not append the disc number to the release title would have to be controlled via some kind of flag, enabled by default.

I think it's very similar in nature to the hard coded usage of disambiguation title, but not identical.

@JoeLametta
Copy link
Collaborator

I think it's very similar in nature to the hard coded usage of disambiguation title, but not identical.

You're right. This issue is currently scheduled for milestone 2.0 but if I have enough time I'll try to complete it for milestone 1.0 :wink

JoeLametta added a commit that referenced this issue May 16, 2021
This pull request extends the supported template variables. Additions:

- `%B`: release barcode (already included but is now allowed)
- `%C`: release catalog number (already included but is now allowed)
- `%c`: release disambiguation comment
- `%D`: disc title without disambiguation
- `%I`: MusicBrainz Disc ID
- `%M`: total number of discs in the chosen release
- `%N`: number of current disc
- `%T`: medium title

When the relative metadata is available, whipper now adds the `TRACKTOTAL`, `DISCTOTAL` and `DISCNUMBER` metadata tags to the audio tracks.

I've also taken the inspiration from pull request #476.

Resolves #401, resolves #440, resolves #448.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Feature New feature Priority: low Low priority Sprintable Small enough to sprint on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants