-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automatically build Docker images #301
Comments
once that is done, the Docker instructions in the README would become:
instead of the |
This is an interesting suggestion, thanks! |
On 2018-10-03 08:54:37, JoeLametta wrote:
This is an interesting suggestion, thanks!
I don't know: maybe it would be a good idea to create a Docker Hub account just for whipper?
I'd say it'd be a good idea to create a org on github, and then each
maintainer can have an individual account on hub for whipper...
but yes, what I have done in other projects is create an org account on
Docker Hub for the team.
ideally, there'd be a 1-to-1 mapping between the two.
|
@anarcat Sorry, I've got no experience with Docker... 🤣 |
On 2018-10-06 03:14:01, JoeLametta wrote:
@anarcat Sorry, I've got no experience with Docker... 🤣
Let me know if I got it right: are you suggesting to [...]
1. move whipper's repository ownership to a GitHub organization
optionally, yes.
2. sign up for a personal Docker Hub account
definitely, yes.
3. then create a Docker Hub organization (for whipper)?
ideally, yes.
the core idea, in any case, is to create an automated build. this can be
done with only step 2 above.
|
All right, in case I perform step 1 later on (after having already enabled the automated build for the current repository, step 2 & 3 done), I expect I can simply switch the Docker Hub target to the GitHub org. repo without having to fiddle with the accounts. |
well, you'd only two step 2: create a personal docker hub account and hook the build there. when you setup a new org on GitHub, you'd just setup a new, matching, org on docker hub as well and ditch the old one. |
Fine, so I sign up on Docker Hub for a personal account, then create an organization (using the account just created) and link the whipper's GitHub (org) repo on to it, right? (sorry, I've never used Docker/Docker Hub before) |
On 2018-10-16 16:25:04, JoeLametta wrote:
Fine, so I sign up on Docker Hub for a personal account, then create an organization (using the account just created) and link the whipper's GitHub (org) repo on to it, right? (sorry, I've never used Docker/Docker Hub before)
that sounds about right! :)
just try it out and let me know what fails...
|
@anarcat joelametta/whipper: done? 😉 |
that looks awesome! congrats :) i've deleted my test repo to avoid any further confusion. unfortunately it seems another repo came up since then, but i guess we can overtake it with a right number of pulls (and stars?): |
Now Docker adopters can use whipper trough Docker Hub's automatically built images. Thanks to user "anarcat" for proposing and thoroughly explaining how to reach this goal. Closes #301.
I've just updated the README: special thanks in f9cb126 's description. 🎉 |
awesome thanks :) |
A key thing of Docker is that there is the Docker hub which automatically builds Docker images for you. This allows users to use your software without having to download (or build!) the source.
There are already two "whipper" Docker images when you search on the hub whipper7/test (probably unrelated) and dartagnan/whipper unofficial build. This means that Docker users are likely to use an unofficial (or totally unrelated) image instead of the one you provide here.
Enabling automated builds of your image is fairly simple:
Create
thenCreate automated build
Create Auto-build Githb
thereSave
Then the build should be automatically triggered when changes are performed in the GitHub repository.
I can assist with the creation process if you grant me access, but it would of course be better if you would get familiar with it.
I went through the above process and created the anarcat/whipper repository based on my fork, as an example. I will delete it as soon as this issue is completed.
Thank you for your attention and hard work!
The text was updated successfully, but these errors were encountered: