Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to configure external executable options #244

Open
RecursiveForest opened this issue Mar 2, 2018 · 4 comments
Open

add ability to configure external executable options #244

RecursiveForest opened this issue Mar 2, 2018 · 4 comments
Labels
Accepted Accepted issue on our roadmap Feature New feature Needed: discussion More discussion needed before anything can be done (or still no agreement has been reached) Needed: patch A pull request is required Priority: medium Medium priority
Milestone

Comments

@RecursiveForest
Copy link
Contributor

whipper currently lacks the ability to adjust common options for underlying commands such as cd-paranoia read speed or flac encoding level. A way to specify arbitrary flags to the encoder, ripper, etc, should be provided in the configuration file, like EAC.

I think this is a natural time to add the ability to specify the exact path of commands like cd-paranoia or flac without the user having to edit their $PATH with each command, and to set the defaults to full paths such as /usr/bin/cd-paranoia.

@JoeLametta JoeLametta modified the milestones: backlog, 2.0 Apr 6, 2018
@JoeLametta JoeLametta added Accepted Accepted issue on our roadmap Priority: medium Medium priority Feature New feature Needed: patch A pull request is required Needed: discussion More discussion needed before anything can be done (or still no agreement has been reached) and removed enhancement labels Nov 12, 2018
@JoeLametta
Copy link
Collaborator

JoeLametta commented Nov 13, 2018

From the closed Pull Request #225:

I hadn't thought of it, but per-drive options are totally in the scope of #244. Should be very easy to implement.

@xmixahlx
Copy link

unsure why replaygain isn't in the scope of whipper (?) redirected here.

then... allowing processing of the output directory would be welcome to fix chmod permissions (600) and add replaygain (metaflac --preserve-modtime --add-replay-gain *.flac). needing to do so manually with each rip is somewhat annoying. i can't be the only one doing this...

@JoeLametta
Copy link
Collaborator

unsure why replaygain isn't in the scope of whipper (?) redirected here.

Well, whipper is just a ripper (not a tagging tool, etc.).

allowing processing of the output directory would be welcome to fix chmod permissions (600)

Could you provide more details about the quoted issue? It seems there's no trace of it in whipper's issue tracker...

Cheers,
JoeLametta

@tlc
Copy link

tlc commented Jan 19, 2019

They're probably referring to #284.

eharris added a commit to eharris/whipper that referenced this issue Sep 15, 2022
Resolves whipper-team#220
Partially addresses whipper-team#244
Provides workaround for whipper-team#234

Signed-off-by: Evan Harris <eharris@puremagic.com>
eharris added a commit to eharris/whipper that referenced this issue Sep 15, 2022
Resolves whipper-team#220
Partially addresses whipper-team#244
Provides workaround for whipper-team#234

Signed-off-by: Evan Harris <eharris@puremagic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Feature New feature Needed: discussion More discussion needed before anything can be done (or still no agreement has been reached) Needed: patch A pull request is required Priority: medium Medium priority
Projects
None yet
Development

No branches or pull requests

4 participants