Fix build and lint warnings

[havardholvik]

Minor cleanup to remove warnings related to missing types.

Tested like

yarn build should not produce any warnings

[havardholvik]

Opted to replace the module declaration of RtcManager in favour of an interface over adding the module as an external in the Rollup build. Mainly because the module RtcManager has never existed in jslib-media 😄

[nandito]

Probably related to a previous PR, but passing the env vars to my sample app does not work as before.

REACT_APP_API_BASE_URL=https://<my-local>:4090 
REACT_APP_SIGNAL_BASE_URL=wss://<my-local>:4070 PORT=3001 yarn start

previously: it used the provided api and signal endpoints
now: it ignores these env vars and use prod endpoints

[havardholvik]

Probably related to a previous PR, but passing the env vars to my sample app does not work as before.

REACT_APP_API_BASE_URL=https://<my-local>:4090 
REACT_APP_SIGNAL_BASE_URL=wss://<my-local>:4070 PORT=3001 yarn start

previously: it used the provided api and signal endpoints now: it ignores these env vars and use prod endpoints

Ive just rebased on development (which included the .env fix) and force pushed. Can you test now?

[thyal]

Types doesn't work for me (CRA)

[thyal]

index.d.ts is present in /dist, but with errors

[thyal]

wait, forget me. I just installed again and now it seems to work

[havardholvik]

index.d.ts is present in /dist, but with errors

Arrrrgh. Ok, reverted to the original plan. Works for me locally now in the different frameworks

[thyal]

🍰

[nandito]

Probably related to a previous PR, but passing the env vars to my sample app does not work as before.

REACT_APP_API_BASE_URL=https://<my-local>:4090 
REACT_APP_SIGNAL_BASE_URL=wss://<my-local>:4070 PORT=3001 yarn start

previously: it used the provided api and signal endpoints now: it ignores these env vars and use prod endpoints

Ive just rebased on development (which included the .env fix) and force pushed. Can you test now?

I pulled your latest changes but still can't override the defaults with env vars. They work in the browser-sdk repo's dotenv file, but don't work in my external test app when I define those vars in the cli command. The variables are passed and visible in the sdk, but not used.

Adding this to RoomConnection.ts:

console.log({
    API_BASE_URL,
    SIGNAL_BASE_URL,
    "process.env": process.env,
});

I get:

If I try to log the envs directly, like:

console.log({
    "process.env.REACT_APP_API_BASE_URL": process.env.REACT_APP_API_BASE_URL,
    "process.env.REACT_APP_SIGNAL_BASE_URL": process.env.REACT_APP_SIGNAL_BASE_URL,
});

I get this build error:

src/lib/react/index.ts → dist/react/index.esm.js...
[!] (plugin rpt2) RollupError: src/lib/RoomConnection.ts:182:7 - error TS1005: ':' expected.

182     ""https://api.whereby.dev"": "https://api.whereby.dev",
          ~~~~~
src/lib/RoomConnection.ts:182:12 - error TS1005: ',' expected.

182     ""https://api.whereby.dev"": "https://api.whereby.dev",
               ~
src/lib/RoomConnection.ts:183:7 - error TS1005: ':' expected.

183     ""wss://signal.appearin.net"": "wss://signal.appearin.net",
          ~~~
src/lib/RoomConnection.ts:183:10 - error TS1005: ',' expected.

183     ""wss://signal.appearin.net"": "wss://signal.appearin.net",
             ~

src/lib/react/index.ts

Probably because rollup aggressively replaces every occurrences of this process.env.REACT_APP_API_BASE_URL with the (almost) real env var. 🤦 (ref)

But

console.log({
    API_BASE_URL,
    SIGNAL_BASE_URL,
    "process.env": process.env,
    "process.env[\"REACT_APP_API_BASE_URL\"]": process.env["REACT_APP_API_BASE_URL"],
    "process.env[\"REACT_APP_SIGNAL_BASE_URL\"]": process.env["REACT_APP_SIGNAL_BASE_URL"],
    "_process.env.REACT_APP_API_BASE_URL": process.env.REACT_APP_API_BASE_URL,
    "_process.env.REACT_APP_SIGNAL_BASE_URL": process.env.REACT_APP_SIGNAL_BASE_URL,
});

Shows:

So wdyt about replacing these lines? https://github.com/whereby/browser-sdk/pull/122/files#diff-acfa4c0c627b7b13abb7d70d6d18f9e335e992d0ae69814600c490c306da5481R176
Is there any reason why we should keep it?

[nandito]

Running

REACT_APP_SIGNAL_BASE_URL=<my-url> REACT_APP_API_BASE_URL=<my-url> yarn build && yalc publish

in the browser-sdk folder creates a build I can use against local stack in my test app. So it works for me too. 👏