test: lockingSpec advisory-lock guards missing for CockroachDB (follow-up to #2665)

[bpamiri]

Describe the bug

#2665 added engine/DB guards to lockingSpec for H2 and SQL Server, but four CockroachDB specs still throw "CockroachDB does not support advisory locks." on every engine (Lucee 6, Lucee 7, BoxLang).

Failing specs (all 4 on CockroachDB)

wheels.model.lockingSpec :: executes callback and returns result
wheels.model.lockingSpec :: releases lock even when callback throws an exception
wheels.model.lockingSpec :: accepts a custom timeout argument
wheels.model.lockingSpec :: safely handles lock names with single quotes

Error message (all four):

CockroachDB does not support advisory locks.

The spec is throwing this message intentionally (CockroachDB genuinely doesn't support advisory locks), but BDD records it as an Error rather than skipping. Need the same skip-guard treatment as H2/SQL Server.

Reproduction

tools/test-matrix.sh lucee7 cockroachdb
# or
curl 'http://localhost:60007/wheels/core/tests?db=cockroachdb&format=json&directory=tests.specs.model'

Evidence

Compat-matrix run 25978222394 (develop, 2026-05-17):

• lucee6/cockroachdb: 4 errors (these specs)
• lucee7/cockroachdb: 4 errors (these specs)
• boxlang/cockroachdb: 4 errors (these specs)

Identical signature across all three engines confirms this is environmental (CockroachDB-specific), not engine-specific.

Expected behavior

The four advisory-lock specs skip cleanly on CockroachDB (as they already do on H2 and SQL Server per #2665), reporting as skipped rather than errored.

Related

• Parent: Core test suite has high failure/error rate on BoxLang (35 failures, 125 errors, 3526 passing) #2649 (BoxLang compat rollup)
• Predecessor: test: lockingSpec advisory-lock + transaction tests need engine guards for H2 and SQL Server #2665 (closed, partial fix)

[wheels-bot]

Wheels Bot — Triage

Classified as bug.

Suspected layer

model — specifically the database-adapter subsystem at vendor/wheels/databaseAdapters/. See .ai/wheels/model/ for canonical patterns.

Fix sketch

vendor/wheels/databaseAdapters/CockroachDB/CockroachDBModel.cfc extends PostgreSQLModel, which overrides $supportsAdvisoryLocks() to return true (PG implements pg_advisory_lock natively). CockroachDB inherits that true, so lockingSpec.cfc:20 never skips, and the four specs proceed to call withAdvisoryLock → $acquireAdvisoryLock, which the CockroachDB adapter throws Wheels.AdvisoryLockNotSupported from (lines 45–51 of CockroachDBModel.cfc).

Fix is mechanical: add a $supportsAdvisoryLocks() override returning false to CockroachDBModel.cfc alongside the existing throwing implementations of $acquireAdvisoryLock / $releaseAdvisoryLock. Mirrors what #2665 did for SQLite/MSSQL via Base.cfc's default-false + adapter-level overrides. No spec changes needed — the beforeEach skip-guard already does the right thing once the capability flag is correct.

Confidence: high

Single-file, single-method override; root cause confirmed by reading the inheritance chain (CockroachDB → PostgreSQL → Base) and the existing $supportsAdvisoryLocks() definitions; no security/middleware/migration/deploy/DI surface touched; not a cross-CFML-engine concern (failure signature is identical across Lucee 6, Lucee 7, BoxLang per the issue's evidence).

<!-- wheels-bot:triage:2743 -->
<!-- wheels-bot:triage-class:bug -->
<!-- wheels-bot:triage-confidence:high -->

[wheels-bot]

Wheels Bot — Fix proposed

Draft PR: #2747

Spec: vendor/wheels/tests/specs/database/CockroachDBUnitSpec.cfc — failing → passing
Implementation: vendor/wheels/databaseAdapters/CockroachDB/CockroachDBModel.cfc

A human review is required before merge. Reviewer A and Reviewer B will weigh in shortly. Doc updates (MDX guides, .ai/wheels/, CLAUDE.md) are handled separately by bot-update-docs.yml.