Add an explicit step to a range match #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, Elixir 1.17 emits a warning for this line.
Pull Request Test Coverage Report for Build c83e3588e67df37d77907aebf33e7a9d83d9a54d-PR-195Details
💛 - Coveralls |
|
CI is failing, mind taking a look? We might have to do this conditionally based on the Elixir version, I’m not sure. I'll be without a laptop til Monday so I can't check til then. |
|
@whatyouhide I have rewritten the pattern matching to use the |
|
Actually, yeah that's a good point. I just dropped support for Elixir 1.11 and fixed this in the latest commit. Thanks @alco 💟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, Elixir 1.17 emits a warning for this line.